From: David Hinds <dhinds@sonic.net>
To: Praveen Srinivasan <praveens@stanford.edu>, torvalds@transmeta.com
Cc: linux-kernel@vger.kernel.org, alan@lxorguk.ukuu.org.uk
Subject: Re: [PATCH] rsrc_mgr.c - null ptr fix for 2.4.4
Date: Thu, 24 May 2001 09:09:20 -0700 [thread overview]
Message-ID: <20010524090920.A24268@sonic.net> (raw)
In-Reply-To: <200105240734.f4O7YB404249@smtp1.Stanford.EDU>
In-Reply-To: <200105240734.f4O7YB404249@smtp1.Stanford.EDU>; from Praveen Srinivasan on Thu, May 24, 2001 at 12:35:17AM -0700
On Thu, May 24, 2001 at 12:35:17AM -0700, Praveen Srinivasan wrote:
> Hi,
> This fixes an unchecked ptr bug in the resource manager code for the PCMCIA
> driver (rsrc_mgr.c).
I would instead suggest:
--- ../linux/./drivers/pcmcia/rsrc_mgr.c Tue Mar 6 19:28:32 2001
+++ ./drivers/pcmcia/rsrc_mgr.c Mon May 7 22:09:09 2001
@@ -189,6 +189,12 @@
/* First, what does a floating port look like? */
b = kmalloc(256, GFP_KERNEL);
+
+ if(b == NULL){
+ printk(" kmalloc failed!\n");
+ return;
+ }
+
memset(b, 0, 256);
for (i = base, most = 0; i < base+num; i += 8) {
if (check_io_resource(i, 8))
prev parent reply other threads:[~2001-05-24 16:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-05-24 7:35 [PATCH] rsrc_mgr.c - null ptr fix for 2.4.4 Praveen Srinivasan
2001-05-24 8:29 ` Seiichi Nakashima
2001-05-24 16:09 ` David Hinds [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010524090920.A24268@sonic.net \
--to=dhinds@sonic.net \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=praveens@stanford.edu \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.