From: Jens Axboe <axboe@suse.de>
To: Alexandr Andreev <andreev@niisi.msk.ru>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Disabling interrupts before block device request call
Date: Sat, 26 May 2001 00:01:19 +0200 [thread overview]
Message-ID: <20010526000119.A23273@suse.de> (raw)
In-Reply-To: <3B0EE8CF.7040502@niisi.msk.ru>
In-Reply-To: <3B0EE8CF.7040502@niisi.msk.ru>; from andreev@niisi.msk.ru on Fri, May 25, 2001 at 07:20:47PM -0400
On Fri, May 25 2001, Alexandr Andreev wrote:
> Hi, list
> In ll_rw_block.c, before calling block device specific request function
> ( i mean do_hd_request, do_ftl_request, ... ) the io_request_lock is
> locking, and all interrupts are disabling. I know, that request handler
> routine have to be atomic, but when we read data from a flash device (
> for example ) we use a timeouts. Where do we have to enable timer
> interrupts, or should we disable all interrupts?
Even with dropping io_request_lock, it's not recommended to sleep inside
the request_fn. WIth plugging, you are basically preventing the other
plugged queues from being run until you return.
You could use a timer or similar to call you on a specified timeout
instead.
--
Jens Axboe
next prev parent reply other threads:[~2001-05-25 22:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-05-25 23:20 Disabling interrupts before block device request call Alexandr Andreev
2001-05-25 22:01 ` Jens Axboe [this message]
2001-05-28 19:07 ` Why timer interrupt is disabled? Alexandr Andreev
2001-05-28 15:36 ` David Woodhouse
2001-05-28 19:24 ` Disabling interrupts before block device request call Alexandr Andreev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010526000119.A23273@suse.de \
--to=axboe@suse.de \
--cc=andreev@niisi.msk.ru \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.