From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Adrian Bunk <bunk@fs.tum.de>
Cc: Abramo Bagnara <abramo@alsa-project.org>,
davem@caip.rutgers.edu, anton@linuxcare.com.au,
Ralf Baechle <ralf@oss.sgi.com>,
linux-kernel@vger.kernel.org
Subject: Re: Inconsistent "#ifdef __KERNEL__" on different architectures
Date: Sun, 27 May 2001 22:42:57 +0100 [thread overview]
Message-ID: <20010527224257.B2702@flint.arm.linux.org.uk> (raw)
In-Reply-To: <3B115279.CE436CEA@alsa-project.org> <Pine.NEB.4.33.0105272301280.8551-100000@mimas.fachschaften.tu-muenchen.de>
In-Reply-To: <Pine.NEB.4.33.0105272301280.8551-100000@mimas.fachschaften.tu-muenchen.de>; from bunk@fs.tum.de on Sun, May 27, 2001 at 11:07:38PM +0200
On Sun, May 27, 2001 at 11:07:38PM +0200, Adrian Bunk wrote:
> I do also explicitely send this mail to the people that seem to be
> responsible for the pieces of code I touch.
>
> I'm not sure whether the compete removal of the "#ifdef __KERNEL__"'s is
> too rude but there are already other architectures that don't have it in
> their architecture specific versions of these files.
You cannot use the kernel atomic/interrupt functions from userspace
on ARM. You cannot disable interrupts in userspace, and therefore the
kernel atomic functions do not work as you expect them to.
If it is to do with code to be included into the kernel, then why aren't
you defining __KERNEL__ ?
Therefore this change (as far as ARM goes) makes zero sense.
--
Russell King (rmk@arm.linux.org.uk) The developer of ARM Linux
http://www.arm.linux.org.uk/personal/aboutme.html
next prev parent reply other threads:[~2001-05-27 21:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-05-27 17:25 Inconsistent "#ifdef __KERNEL__" on different architectures Adrian Bunk
2001-05-27 17:29 ` Alan Cox
2001-05-27 19:16 ` Abramo Bagnara
2001-05-27 21:07 ` Adrian Bunk
2001-05-27 21:42 ` Russell King - ARM Linux [this message]
2001-05-27 22:10 ` Philip Blundell
2001-05-29 22:30 ` Ralf Baechle
2001-06-02 20:29 ` Adrian Bunk
2001-06-05 4:09 ` Paul Mackerras
2001-06-05 9:33 ` Adrian Bunk
2001-06-05 12:15 ` Paul Mackerras
2001-06-06 6:51 ` Albert D. Cahalan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010527224257.B2702@flint.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=abramo@alsa-project.org \
--cc=anton@linuxcare.com.au \
--cc=bunk@fs.tum.de \
--cc=davem@caip.rutgers.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=ralf@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.