From: Andrzej Krzysztofowicz <ankry@pg.gda.pl>
To: dwmw2@infradead.org (David Woodhouse)
Cc: alan@lxorguk.ukuu.org.uk (Alan Cox),
andrewm@uow.edu.au, p_gortmaker@yahoo.com,
linux-kernel@vger.kernel.org (kernel list)
Subject: Re: [PATCH] net #3
Date: Wed, 30 May 2001 12:11:37 +0200 (MET DST) [thread overview]
Message-ID: <200105301011.MAA17517@sunrise.pg.gda.pl> (raw)
In-Reply-To: <29071.991213917@redhat.com> from "David Woodhouse" at May 30, 2001 10:11:57 AM
"David Woodhouse wrote:"
>
> ankry@green.mif.pg.gda.pl said:
> > -#ifdef CONFIG_ISAPNP
> > +#if defined(CONFIG_ISAPNP) || (defined(CONFIG_ISAPNP_MODULE) && defined(MODULE))
>
> The result here would be a 3c509 module which differs depending on whether
> the ISAPNP module happened to be compiled at the same time or not.
I'm just thinking whether the ISA PnP hardware related modules should depend
on isa-pnp.o at all
(I mean having different behaviour of a the SAME (compiled) module depending
on whether isa-pnp.o is available or not)
It is just adding some persistent pointers for isa-pnp functions to the
kernel and teaching the modules to use request_module(). Probably also some
hacking to keep away from already used ISA PnP hardware during
initialization...
Also implementing "nopnp" option should be mandatory, IMHO.
> The ISAPNP-specific parts of the code aren't large. Please consider
> including them unconditionally instead.
I see no objection if __init for modules is implemented...
Andrzej
--
=======================================================================
Andrzej M. Krzysztofowicz ankry@mif.pg.gda.pl
phone (48)(58) 347 14 61
Faculty of Applied Phys. & Math., Technical University of Gdansk
next prev parent reply other threads:[~2001-05-30 10:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-05-30 0:41 [PATCH] net #3 Andrzej Krzysztofowicz
2001-05-30 5:49 ` Paul Gortmaker
2001-05-30 10:53 ` Andrzej Krzysztofowicz
2001-05-30 12:03 ` Keith Owens
2001-05-30 9:11 ` David Woodhouse
2001-05-30 10:11 ` Andrzej Krzysztofowicz [this message]
2001-05-30 10:39 ` Jeff Garzik
2001-05-30 11:02 ` Andrzej Krzysztofowicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200105301011.MAA17517@sunrise.pg.gda.pl \
--to=ankry@pg.gda.pl \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=andrewm@uow.edu.au \
--cc=ankry@green.mif.pg.gda.pl \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=p_gortmaker@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.