From: Pavel Machek <pavel@suse.cz>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>,
Andrzej Krzysztofowicz <ankry@green.mif.pg.gda.pl>
Cc: Jeff Garzik <jgarzik@mandrakesoft.com>,
Philip.Blundell@pobox.com,
kernel list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] net #6
Date: Thu, 31 May 2001 00:24:37 +0200 [thread overview]
Message-ID: <20010531002437.A21681@bug.ucw.cz> (raw)
In-Reply-To: <200105300044.CAA04542@green.mif.pg.gda.pl> <E1550vA-0005Xe-00@the-village.bc.nu>
In-Reply-To: <E1550vA-0005Xe-00@the-village.bc.nu>; from Alan Cox on Wed, May 30, 2001 at 09:01:36AM +0100
Hi!
> They are neccessary
>
> > @@ -643,9 +631,7 @@
> > eexp_hw_tx_pio(dev,data,length);
> > }
> > dev_kfree_skb(buf);
> > -#ifdef CONFIG_SMP
> > spin_unlock_irqrestore(&lp->lock, flags);
> > -#endif
> > enable_irq(dev->irq);
> > return 0;
>
> They are done this way to get good non SMP performance. Your changes would
> ruin that.
Maybe macro "spin_lock_irqsave_on_smp()" would be good idea? These
ifdefs look ugly. Maybe local to driver, maybe even global.
Pavel
--
I'm pavel@ucw.cz. "In my country we have almost anarchy and I don't care."
Panos Katsaloulis describing me w.r.t. patents at discuss@linmodems.org
next prev parent reply other threads:[~2001-05-31 19:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-05-30 0:44 [PATCH] net #6 Andrzej Krzysztofowicz
2001-05-30 8:01 ` Alan Cox
2001-05-30 10:35 ` Andrzej Krzysztofowicz
2001-05-30 22:24 ` Pavel Machek [this message]
2001-05-31 21:35 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010531002437.A21681@bug.ucw.cz \
--to=pavel@suse.cz \
--cc=Philip.Blundell@pobox.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=ankry@green.mif.pg.gda.pl \
--cc=jgarzik@mandrakesoft.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.