From: Lukas Schroeder <lukas@edeal.de>
To: Ben Pfaff <pfaffben@msu.edu>
Cc: Alan Cox <alan@redhat.com>, Lukas Schroeder <lukas@edeal.de>,
zab@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [patch] ess maestro, support for hardware volume control
Date: Tue, 12 Jun 2001 14:31:42 +0200 [thread overview]
Message-ID: <20010612143142.A17450@kosmo.edeal.de> (raw)
In-Reply-To: <200106091931.f59JVw731673@devserv.devel.redhat.com> <87elst2vr2.fsf@pfaffben.user.msu.edu>
In-Reply-To: <87elst2vr2.fsf@pfaffben.user.msu.edu>
the little patch below (vs. 2.4.5-ac13) fixes a freeze which happens
when the maestro module was unloaded and a HWV button gets pushed
generating the interrupt. so this disables all irqs of that chip
on remove...
regards,
lukas
--- linux-2.4.5-ac13/drivers/sound/maestro.c Tue Jun 12 13:41:24 2001
+++ linux/drivers/sound/maestro.c Tue Jun 12 14:13:40 2001
@@ -3575,6 +3575,12 @@
struct ess_card *card = pci_get_drvdata(pcidev);
int i;
+ /* turn off all irqs; _especially_ the one for hardware volume
+ control (bit 6), which locks the machine dead when occurring after
+ the maestro module was removed.
+ */
+ outw(0x0, card->iobase+0x18);
+
/* XXX maybe should force stop bob, but should be all
stopped by _release by now */
free_irq(card->irq, card);
prev parent reply other threads:[~2001-06-12 12:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-06-09 17:09 [patch] ess maestro, support for hardware volume control Lukas Schroeder
2001-06-09 17:25 ` Zach Brown
2001-06-09 18:16 ` Lukas Schroeder
2001-06-09 18:50 ` Zach Brown
2001-06-09 18:58 ` Alan Cox
2001-06-09 19:31 ` Alan Cox
2001-06-09 21:23 ` Ben Pfaff
2001-06-09 22:52 ` Zach Brown
2001-06-10 10:10 ` Abramo Bagnara
2001-06-09 23:36 ` Alan Cox
2001-06-10 3:43 ` Ben Pfaff
2001-06-10 13:08 ` Alan Cox
2001-06-10 17:53 ` Riley Williams
2001-06-12 12:31 ` Lukas Schroeder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010612143142.A17450@kosmo.edeal.de \
--to=lukas@edeal.de \
--cc=alan@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pfaffben@msu.edu \
--cc=zab@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.