Re: [PATCH] add kmalloc check in drviers/pcmcia/rsrc_mgr.c (245-ac16)

[Arnaldo Carvalho de Melo <acme@conectiva.com.br>]

Em Sat, Jun 23, 2001 at 07:09:37PM +0200, Eric Lammerts escreveu:
> 
> On Sat, 23 Jun 2001, Rasmus Andersen wrote:
> 
> > +    if (!b) {
> > +	printk(" -- aborting.\n");
> > +	printk(KERN_ERR "Out of memory.");
> > +	return;
> > +    }
> 
> Why not printk(KERN_ERR "rsrc_mgr: Out of memory.\n"); ?
> Then at least people will know what it was that ran out of memory.

Better yet:

printk(KERN_ERR __FUNCTION__ "Out of memory.");

Then if you move the code to other function or if you change the name of
the function you don't have to go all over the code doing
s/old_function_name/new_function_name/g

- Arnaldo