Re: [PATCH] catch potential null derefs in drivers/char/ip2main.c (245ac16)

[Rasmus Andersen <rasmus@jaquet.dk>]

On Sun, Jun 24, 2001 at 07:14:00PM -0400, Michael H. Warfield wrote:
[...] 
> 	I'm responsible for the kernel / driver integration end of it
> anyways.
> 
> 	I'll find out what's up with Doug, but this is my issue to deal
> with anyways.  And yes, I'm looking at it.  I've got a couple of other
> patches on the back burner that are overdue for integration.

The pB deref below kinda bothers me. It is last set way above as
part of looping through stuff comparing it to NULL. It seems
bogus to use is as below but I have no clue what should be used
instead.

[..]
> > -			for ( box = 0; box < ABS_MAX_BOXES; ++box )
> > -			{
> > -			    for ( j = 0; j < ABS_BIGGEST_BOX; ++j )
> > -			    {
> > -				if ( pB->i2eChannelMap[box] & (1 << j) )
> > +				for ( box = 0; box < ABS_MAX_BOXES; ++box )
> >  				{

Regards,
  Rasmus