From: "François romieu" <romieu@zoreil.com>
To: "Robert J.Dunlop" <rjd@xyzzy.clara.co.uk>
Cc: linux-kernel@vger.kernel.org
Subject: Re: New FarSync T-Series driver
Date: Wed, 4 Jul 2001 16:18:45 +0200 [thread overview]
Message-ID: <20010704161845.A27070@zoreil.com> (raw)
In-Reply-To: <20010703182803.A13853@xyzzy.clara.co.uk>
The Tue, Jul 03, 2001 at 06:28:03PM +0100, Robert J.Dunlop wrote :
[...]
> Sorry for the big post, but I posted URLs for an earlier version of this
> a couple of months back and got very little feedback. I know sync card
> drivers ain't sexy.
Just my HO:
* error_1, error_2... error_n labels are ugly;
* ioremap may fail;
* mix of spin_lock and FST_LOCK isn't nice (kill the latter ?);
*
+ offset = BUF_OFFSET ( rxBuffer[pi][i]);
[...]
+ card->mem + BUF_OFFSET ( rxBuffer[pi][rxp][0]),
A bit of a macro abuse imho.
*
+ if ( ++port->txpos >= NUM_TX_BUFFER )
+ port->txpos = 0;
Why not:
port->txpos++;
foo = port->txpos%NUM_TX_BUFFER;
--
Ueimor
next prev parent reply other threads:[~2001-07-04 14:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-07-03 17:28 New FarSync T-Series driver Robert J.Dunlop
2001-07-04 14:18 ` François romieu [this message]
2001-07-09 15:19 ` Robert J.Dunlop
2001-07-26 14:51 ` FarSync T-Series tweak and question Robert J.Dunlop
2001-07-27 16:11 ` François romieu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010704161845.A27070@zoreil.com \
--to=romieu@zoreil.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rjd@xyzzy.clara.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.