From: Grant Grundler <grundler@puffin.external.hp.com>
To: Matthew Wilcox <willy@debian.org>
Cc: parisc-linux@parisc-linux.org
Subject: Re: [parisc-linux] I think WAX is broken
Date: Sun, 08 Jul 2001 19:03:20 -0600 [thread overview]
Message-ID: <200107090103.TAA09348@puffin.external.hp.com> (raw)
In-Reply-To: Message from Matthew Wilcox <willy@debian.org> of "Mon, 09 Jul 2001 00:44:02 BST." <20010709004402.Q6103@parcelfarce.linux.theplanet.co.uk>
Matthew Wilcox wrote:
...
> `addr' is a u16. it can't possibly be >= 0x00080000 or >= 0x00500000.
Yup - that's definitely broken.
...
> Then in arch/parisc/kernel/pci.c, we have the wonderfully obscured:
Hey! that's mine! :^P
...
> So I _think_ the right fix is to change WAX_EISA_OUT to:
>
> #define WAX_EISA_OUT(type, size) \
> static void wax_out##type (struct pci_hba_data *hba, u16 addr, u##size d) \
> { \
> u32 out_addr = 0xfc000000 + ((addr & 0xfc00) >> 6) + \
> ((addr & 0x03f8) << 9) + (addr & 0x0007) ; \
> gsc_write##type(d,out_addr); \
> }
Someone needs to understand what "((addr & 0xfc00) >> 6)" does.
It looks like it overlaps with "((addr & 0x03f8) << 9)".
grant
Grant Grundler
parisc-linux {PCI|IOMMU|SMP} hacker
+1.408.447.7253
next prev parent reply other threads:[~2001-07-09 1:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-07-08 23:44 [parisc-linux] I think WAX is broken Matthew Wilcox
2001-07-09 1:03 ` Grant Grundler [this message]
2001-07-09 1:30 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200107090103.TAA09348@puffin.external.hp.com \
--to=grundler@puffin.external.hp.com \
--cc=parisc-linux@parisc-linux.org \
--cc=willy@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.