All of lore.kernel.org
 help / color / mirror / Atom feed
From: Konstantin Volckov <goldhead@altlinux.ru>
To: linux-kernel@vger.kernel.org
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
	"Edward Peng." <edward_peng@dlink.com.tw>
Subject: PATCH for dl2k driver
Date: Tue, 10 Jul 2001 22:24:17 +0400	[thread overview]
Message-ID: <20010710222417.26dedb99.goldhead@altlinux.ru> (raw)

[-- Attachment #1: Type: text/plain, Size: 188 bytes --]

Hi!

There is a mistake in dl2k.c network driver added in 2.4.6-ac2.

Without this patch gcc-2.95.3 produces a broken symbol __ucmpdi2, while
gcc-2.96 works ok.

-- 
Good luck,
Konstantin

[-- Attachment #2: linux-2.4.6-ac2-dl2k.patch --]
[-- Type: application/octet-stream, Size: 681 bytes --]

--- linux/drivers/net/dl2k.c_old	Tue Jul 10 19:05:33 2001
+++ linux/drivers/net/dl2k.c	Tue Jul 10 22:11:21 2001
@@ -559,7 +559,7 @@
 			}
 		}
 		/* Free used tx skbuffs */
-		for (; np->cur_tx - np->old_tx > 0; np->old_tx++) {
+		for (; np->cur_tx > np->old_tx; np->old_tx++) {
 			int entry = np->old_tx % TX_RING_SIZE;
 			if (!(np->tx_ring[entry].status & TFDDone))
 				break;
@@ -710,7 +710,7 @@
 	}
 
 	/* Re-allocate skbuffs to fill the descriptor ring */
-	for (; np->cur_rx - np->old_rx > 0; np->old_rx++) {
+	for (; np->cur_rx > np->old_rx; np->old_rx++) {
 		struct sk_buff *skb;
 		entry = np->old_rx % RX_RING_SIZE;
 		/* Dropped packets don't need to re-allocate */

             reply	other threads:[~2001-07-10 18:25 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-07-10 18:24 Konstantin Volckov [this message]
2001-07-10 19:17 ` PATCH for dl2k driver Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20010710222417.26dedb99.goldhead@altlinux.ru \
    --to=goldhead@altlinux.ru \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=edward_peng@dlink.com.tw \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.