All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andreas Dilger <adilger@turbolinux.com>
To: torvalds@transmeta.com, Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Linux kernel development list <linux-kernel@vger.kernel.org>,
	Ext2 development mailing list  <ext2-devel@lists.sourceforge.net>
Subject: [PATCH] comment out obsolete ext2 code
Date: Wed, 11 Jul 2001 16:42:01 -0600 (MDT)	[thread overview]
Message-ID: <200107112242.f6BMg1M8009860@webber.adilger.int> (raw)

This patch comments out code in ext2 which is obsolete, or was never used
in the first place (i.e. future vision stuff, etc).  In particular, the
inode->i_attr_flags field is not used anywhere else in the kernel, and it
is only set, but not referenced in the ext2 code.  It could probably be
deleted entirely (saving 4 bytes in struct inode).

Similarly, the ext2_notify_change() function is not currently in use (but
it may be needed at some time in the future).  However, per previous
discussions with Stephen on ext2-devel, the 2.4 code is buggy (2.2 code
was fixed), so even though it is currently unused I have fixed it.  The
brokenness in question also relates to i_attr_flags, so it could also
be deleted entirely if that is the goal.

There are a couple of other obsolete bits not removed by this patch,
namely i_osync, and i_new_inode in ext2_inode_info.  Another day...

Cheers, Andreas
-- 
Andreas Dilger  \ "If a man ate a pound of pasta and a pound of antipasto,
                 \  would they cancel out, leaving him still hungry?"
http://www-mddsp.enel.ucalgary.ca/People/adilger/               -- Dogbert

             reply	other threads:[~2001-07-11 22:43 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-07-11 22:42 Andreas Dilger [this message]
  -- strict thread matches above, loose matches on Subject: below --
2001-07-11 22:52 [PATCH] comment out obsolete ext2 code Andreas Dilger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200107112242.f6BMg1M8009860@webber.adilger.int \
    --to=adilger@turbolinux.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=ext2-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.