From: Pete Zaitcev <zaitcev@redhat.com>
To: dwmw2@infradead.org, Chris Wedgwood <cw@f00f.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: (patch-2.4.6) Fix oops with Iomega Clik! (ide-floppy)
Date: Sat, 14 Jul 2001 14:36:42 -0400 [thread overview]
Message-ID: <200107141836.f6EIagB30800@devserv.devel.redhat.com> (raw)
In-Reply-To: <mailman.995129400.8760.linux-kernel2news@redhat.com>
In-Reply-To: <20010715031815.D6722@weta.f00f.org> <200107141414.f6EEEjQ05792@ns.caldera.de> <mailman.995129400.8760.linux-kernel2news@redhat.com>
In linux-kernel, you wrote:
> cw@f00f.org said:
> > Linus, please consider applying the following patch.
> >
> > --- linux-2.4.7-pre6/include/linux/malloc.h Thu Jul 12 03:53:53 2001
> > +++ linux-2.4.7-pre6+mallocRIP/include/linux/malloc.h Thu Jan 1 12:00:00 1970
> > @@ -1,5 +0,0 @@
> > -#ifndef _LINUX_MALLOC_H
> > -#define _LINUX_MALLOC_H
> > -
> > -#include <linux/slab.h>
> > -#endif /* _LINUX_MALLOC_H */
>
> Doing that in the middle of a supposedly stable series, even if it wasn't a
> fundamentally stupid thing to do in the first place, isn't really very
> sensible.
>
> --
> dwmw2
It would be much better to add something like this:
#warning "Please use slab.h instead"
The patch above should be put off until the 2.5.
-- Pete
prev parent reply other threads:[~2001-07-14 18:37 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-07-14 10:38 (patch-2.4.6) Fix oops with Iomega Clik! (ide-floppy) Gunther Mayer
2001-07-14 12:15 ` Alan Cox
2001-07-14 15:00 ` Paul Bristow
2001-07-14 14:14 ` Christoph Hellwig
2001-07-14 15:18 ` Chris Wedgwood
2001-07-14 16:41 ` David Woodhouse
2001-07-14 16:47 ` David Woodhouse
2001-07-14 16:58 ` Chris Wedgwood
2001-07-14 17:02 ` Alan Cox
2001-07-14 17:11 ` Chris Wedgwood
2001-07-14 17:29 ` Jeff Garzik
2001-07-14 17:33 ` Alan Cox
2001-07-14 17:38 ` Jeff Garzik
2001-07-14 17:44 ` Alan Cox
2001-07-14 18:04 ` __KERNEL__ removal Jonathan Lundell
2001-07-14 18:19 ` Jeff Garzik
2001-07-14 18:30 ` Mo McKinlay
2001-07-15 11:53 ` Kai Henningsen
2001-07-15 13:12 ` Chris Wedgwood
2001-07-15 14:21 ` Horst von Brand
2001-07-16 9:16 ` Chris Wedgwood
2001-07-14 18:12 ` (patch-2.4.6) Fix oops with Iomega Clik! (ide-floppy) Wichert Akkerman
2001-07-15 3:40 ` Chris Wedgwood
2001-07-15 3:46 ` Jeff Garzik
2001-07-15 3:56 ` Chris Wedgwood
2001-07-14 18:09 ` David Woodhouse
2001-07-14 18:21 ` Jeff Garzik
2001-07-14 18:49 ` David Woodhouse
[not found] ` <mailman.995129400.8760.linux-kernel2news@redhat.com>
2001-07-14 18:36 ` Pete Zaitcev [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200107141836.f6EIagB30800@devserv.devel.redhat.com \
--to=zaitcev@redhat.com \
--cc=cw@f00f.org \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.