All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrzej Krzysztofowicz <kufel!ankry@green.mif.pg.gda.pl>
To: kufel!oph.rwth-aachen.de!stefan@green.mif.pg.gda.pl (Stefan Becker)
Cc: kufel!lxorguk.ukuu.org.uk!alan@green.mif.pg.gda.pl (Alan Cox),
	kufel!vger.kernel.org!linux-kernel@green.mif.pg.gda.pl
Subject: Re: [PATCH] init/main.c
Date: Sat, 21 Jul 2001 23:39:40 +0200 (CEST)	[thread overview]
Message-ID: <200107212139.XAA12131@kufel.dom> (raw)
In-Reply-To: <Pine.LNX.4.21.0107211840250.27803-100000@die-macht> from "Stefan Becker" at lip 21, 2001 06:51:07

Hi,
   What do you aim at doing this changes ?

> The following patch against 2.4.6-ac5 does
[...]
> (b) wraps certain root_dev_names[] into #ifdefs.
>     I hope I found the correct CONFIG_BLK_* variables
[...]
>  #endif
> +#ifdef CONFIG_BLK_DEV_DAC960
>  	{ "rd/c0d0p",0x3000 },
>  	{ "rd/c0d1p",0x3008 },
>  	{ "rd/c0d2p",0x3010 },
> @@ -296,6 +298,8 @@
>  	{ "rd/c0d13p",0x3068 },
>  	{ "rd/c0d14p",0x3070 },
>  	{ "rd/c0d15p",0x3078 },
> +#endif
> +#ifdef CONFIG_BLK_CPQ_DA
... etc.

AFAIR, the above (and similar) #ifdefs were intentionally removed as they
break using root=... kernel parameters for apropriate drivers loaded as
module from initrd. In these cases there are 3 solutions:

1. Use numeric values (not convenient)
2. #if defined(CONFIG_FOO) || defined(CONFIG_FOO_MODULE)
   This is ugly (main kernel depends on too many module settings).
   Also, Linux (Alan too ?) hate too many unnecessary
3. Remove all #ifdefs here. (prefered as this is init code...)

Alan, please DON'T apply this patch.

Andrzej


  parent reply	other threads:[~2001-07-21 22:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-07-21 16:51 [PATCH] init/main.c Stefan Becker
2001-07-21 17:05 ` Alexander Griesser
2001-07-21 17:36 ` Robert Love
2001-07-21 21:39 ` Andrzej Krzysztofowicz [this message]
2001-07-22  3:58   ` Stefan Becker
2001-07-22  4:05     ` Keith Owens

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200107212139.XAA12131@kufel.dom \
    --to=kufel!ankry@green.mif.pg.gda.pl \
    --cc=kufel!lxorguk.ukuu.org.uk!alan@green.mif.pg.gda.pl \
    --cc=kufel!oph.rwth-aachen.de!stefan@green.mif.pg.gda.pl \
    --cc=kufel!vger.kernel.org!linux-kernel@green.mif.pg.gda.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.