Re: [PATCH] i2c update to 2.6.0 for 2.4.7

["J . A . Magallon" <jamagallon@able.es>]

On 20010725 J . A . Magallon wrote:
>
>On 20010725 Tom Rini wrote:
>>On Wed, Jul 25, 2001 at 02:46:29AM +0200, J . A . Magallon wrote:
>>> Hi.
>>> 
>>> This patch updates i2c support in kernel to 2.6.0. I have corrected original patch
>>> to use slab.h instead of malloc.h, a couple #endif's, and Comfigure.help references
>>> to other docs in <file:...> format.
>>
>>It appears to be missing new files.  The rpx and 405 bits aren't all there.
>>
>
>Correct, the original patch generator skips them, both in 2.6.0 and latest cvs.
>Why ?
>Will redo the patch...
>

I have been looking at that part, and seems like pretty half-done, even buggy.
Can't you live without it ?

For example, in mkpatch/Config.in:

   if [ "$CONFIG_8xx" = "y" ]; then
<well, there is a 8xx cpu variable in arch/ppc>
...
   if [ "$CONFIG_405" = "y" ]; then
<I found no _405, should not it be _4xx ?>
      dep_tristate 'PPC 405 I2C Algorithm' CONFIG_I2C_PPC405_ALGO $CONFIG_I2C
                               look at this ^^^^^^^^^^^^^^^^^^^^
      if [ "CONFIG_PPC405_I2C_ALGO" != "n" ]; then
     <vs this ^^^^^^^^^^^^^^^^^^^^ >
         dep_tristate '  PPC 405 I2C Adapter' CONFIG_I2C_PPC405_ADAP $CONFIG_I2C
_PPC405_ALGO

I would not trust that part still.

BTW, I sent the patches about slab/malloc to the mantainer time ago, and cvs
still uses malloc. 

-- 
J.A. Magallon                           #  Let the source be with you...        
mailto:jamagallon@able.es
Mandrake Linux release 8.1 (Cooker) for i586
Linux werewolf 2.4.7 #1 SMP Mon Jul 23 01:55:36 CEST 2001 i686