From: Christoph Hellwig <hch@ns.caldera.de>
To: trond.myklebust@fys.uio.no (Trond Myklebust)
Cc: alan@redhat.com, linux-kernel@vger.kernel.org, adam@yggdrasil.com
Subject: Re: linux-2.4.9: atomic_dec_and_lock sometimes used while not defined
Date: Fri, 17 Aug 2001 12:31:10 +0200 [thread overview]
Message-ID: <200108171031.f7HAVAc16023@ns.caldera.de> (raw)
In-Reply-To: <shsu1z7c7qa.fsf@charged.uio.no>
Hi Trond,
In article <shsu1z7c7qa.fsf@charged.uio.no> you wrote:
> diff -u --recursive --new-file linux-2.4.9.orig/lib/Makefile linux-2.4.9/lib/Makefile
> --- linux-2.4.9.orig/lib/Makefile Wed Apr 25 22:31:03 2001
> +++ linux-2.4.9/lib/Makefile Fri Aug 17 11:52:35 2001
> @@ -16,6 +16,7 @@
> obj-$(CONFIG_RWSEM_XCHGADD_ALGORITHM) += rwsem.o
>
> ifneq ($(CONFIG_HAVE_DEC_LOCK),y)
> + export-objs += dec_and_lock.o
> obj-y += dec_and_lock.o
> endif
Nonono! Please add it to export-objs _always_ not dependand on some
CONFIG_ symbol, that's how the 2.4 makefiles work.
Christoph
--
Of course it doesn't work. We've performed a software upgrade.
next prev parent reply other threads:[~2001-08-17 10:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-08-16 18:21 linux-2.4.9: atomic_dec_and_lock sometimes used while not defined Adam J. Richter
2001-08-17 9:20 ` Trond Myklebust
2001-08-17 10:15 ` Trond Myklebust
2001-08-17 10:31 ` Christoph Hellwig [this message]
2001-08-17 10:40 ` Trond Myklebust
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200108171031.f7HAVAc16023@ns.caldera.de \
--to=hch@ns.caldera.de \
--cc=adam@yggdrasil.com \
--cc=alan@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=trond.myklebust@fys.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.