From: Goetz Bock <bock@blacknet.de>
To: linux-lvm@sistina.com
Subject: Re: [linux-lvm] Problem using lvreduce
Date: Fri, 17 Aug 2001 15:05:40 +0200 [thread overview]
Message-ID: <20010817150540.A19093@dragon.blacknet.de> (raw)
In-Reply-To: <20010817114344.D450@btconnect.com>; from thornber@btconnect.com on Fri, Aug 17, 2001 at 11:43:44AM +0100
[-- Attachment #1: Type: text/plain, Size: 986 bytes --]
On Fri, Aug 17 '01 at 11:43, Joe Thornber wrote:
> > --- pv_release_pe.c.old Thu Aug 16 09:23:35 2001
> > +++ pv_release_pe.c Wed Aug 15 09:09:06 2001
> > @@ -85,7 +85,7 @@
> > }
> > pe_index = ( vg->lv[l]->lv_current_pe[p].pe -
> > LVM_VGDA_SIZE ( vg->pv[pv_num]) / SECTOR_SIZE) /
> > - vg->pe_size;
> > + vg->pe_size - 1;
> > debug ( "pv_release_pe -- pv_name: %s pe: %lu sector: %lu\n",
> > vg->pv[pv_num]->pv_name,
> > pe_index,
>
> This patch looks wrong, I cant see why anyone would want to divide by
> pe_size - 1, if it's working it's by accident.
Disclamer: I did not lok at the code, and don't know what IŠm talking
about ...
But, what this patch does, is devide by pe_size and substract 1 from the
result.
--
Goetz Bock IT Consultant
Dipl.-Inf. Univ.
[-- Attachment #2: Type: application/pgp-signature, Size: 232 bytes --]
next prev parent reply other threads:[~2001-08-17 13:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-08-16 17:06 [linux-lvm] Problem using lvreduce Soohoon Lee
2001-08-16 20:19 ` Faux Pas III
2001-08-17 10:43 ` Joe Thornber
2001-08-17 13:05 ` Goetz Bock [this message]
2001-08-17 13:14 ` Joe Thornber
2001-08-17 14:38 ` Heinz J . Mauelshagen
2001-08-17 15:41 ` Faux Pas III
2001-08-18 10:04 ` Joe Thornber
2001-08-20 4:05 ` Faux Pas III
-- strict thread matches above, loose matches on Subject: below --
2001-08-17 15:33 Soohoon Lee
2001-08-15 23:50 Faux Pas III
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010817150540.A19093@dragon.blacknet.de \
--to=bock@blacknet.de \
--cc=linux-lvm@sistina.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.