From: Roger Larsson <roger.larsson@norran.net>
To: Rik van Riel <riel@conectiva.com.br>
Cc: linux-mm@kvack.org
Subject: Re: [PATCH NG] alloc_pages_limit & pages_min
Date: Thu, 23 Aug 2001 20:36:39 +0200 [thread overview]
Message-ID: <200108231841.f7NIf3001564@mailf.telia.com> (raw)
In-Reply-To: <Pine.LNX.4.33L.0108222139350.5646-100000@imladris.rielhome.conectiva>
On Thursdayen den 23 August 2001 02:40, Rik van Riel wrote:
> On Thu, 23 Aug 2001, Roger Larsson wrote:
> > + if (page) {
> > + while (z->free_pages < z->pages_low) {
> > + struct page *extra = reclaim_page(z);
> > + if (!extra)
> > + break;
> > + __free_page(extra);
> > + }
> > + }
>
> This is a surprise ;)
>
> Why did you introduce this piece of code?
> What is it supposed to achieve ?
>
f we did get one page => we are above pages_min
try to reach pages_low too.
But holding on to the page we got.
It is possible that it should only be done if we started under
pages_min. But it will be faster the closer we start to pages_low
/RogerL
--
Roger Larsson
Skelleftea
Sweden
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/
next prev parent reply other threads:[~2001-08-23 18:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-08-22 23:46 [PATCH NG] alloc_pages_limit & pages_min Roger Larsson
2001-08-23 0:40 ` Rik van Riel
2001-08-23 18:36 ` Roger Larsson [this message]
2001-08-23 18:44 ` Rik van Riel
2001-08-23 18:52 ` Roger Larsson
2001-08-23 19:03 ` Rik van Riel
2001-08-23 19:28 ` Upd: " Roger Larsson
2001-08-23 19:28 ` Roger Larsson
2001-08-24 9:25 ` Stephan von Krawczynski
2001-08-24 10:28 ` Roger Larsson
2001-08-24 12:50 ` Stephan von Krawczynski
2001-08-23 18:45 ` Roger Larsson
2001-08-23 18:55 ` Rik van Riel
-- strict thread matches above, loose matches on Subject: below --
2001-08-23 18:12 Roger Larsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200108231841.f7NIf3001564@mailf.telia.com \
--to=roger.larsson@norran.net \
--cc=linux-mm@kvack.org \
--cc=riel@conectiva.com.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.