Re: scr_*() audit

[Olaf Hering <olh@suse.de>]

On Thu, Aug 23, Olaf Hering wrote:

> On Wed, Aug 22, Geert Uytterhoeven wrote:
> 
> > +				q++
> 
> typo :)
> 
> > diff -ur linux-2.4.8-ac9/drivers/video/hgafb.c scr-audit-2.4.8-ac9/drivers/video/hgafb.c
> > --- linux-2.4.8-ac9/drivers/video/hgafb.c	Mon May 28 11:07:02 2001
> > +++ scr-audit-2.4.8-ac9/drivers/video/hgafb.c	Wed Aug 22 18:48:32 2001
> > @@ -203,7 +203,7 @@
> >  		fillchar = 0x00;
> >  	spin_unlock_irqrestore(&hga_reg_lock, flags);
> >  	if (fillchar != 0xbf)
> > -		memset((char *)hga_vram_base, fillchar, hga_vram_len);
> > +		isa_memset_io((char *)hga_vram_base, fillchar, hga_vram_len);
> >  }
> >  
> >  
> > @@ -279,7 +279,8 @@
> >  	char *logo = linux_logo_bw;
> >  	for (y = 134; y < 134 + 80 ; y++) /* this needs some cleanup */
> >  		for (x = 0; x < 10 ; x++)
> > -			*(dest + (y%4)*8192 + (y>>2)*90 + x + 40) = ~*(logo++);
> > +			isa_writeb(~*(logo++),
> > +				   (dest + (y%4)*8192 + (y>>2)*90 + x + 40));
> >  }

--- hgafb.c     Thu Aug 23 23:19:58 2001
+++ drivers/video/hgafb.c       Fri Aug 24 13:02:57 2001
@@ -203,7 +203,7 @@
                fillchar = 0x00;
        spin_unlock_irqrestore(&hga_reg_lock, flags);
        if (fillchar != 0xbf)
-               isa_memset_io((char *)hga_vram_base, fillchar, hga_vram_len);
+               isa_memset_io(hga_vram_base, fillchar, hga_vram_len);
 }


@@ -280,7 +280,7 @@
        for (y = 134; y < 134 + 80 ; y++) /* this needs some cleanup */
                for (x = 0; x < 10 ; x++)
                        isa_writeb(~*(logo++),
-                                  (dest + (y%4)*8192 + (y>>2)*90 + x + 40));
+                                  *(dest + (y%4)*8192 + (y>>2)*90 + x + 40));
 }
 #endif /* MODULE */



Anyone with a hercules card around? Do they still work?



Gruss Olaf

-- 
 $ man clone

BUGS
       Main feature not yet implemented...