All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pete Zaitcev <zaitcev@redhat.com>
To: Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: PROBLEM: usb not working with 2.4.8-ac8
Date: Fri, 24 Aug 2001 17:38:05 -0400	[thread overview]
Message-ID: <200108242138.f7OLc5D12711@devserv.devel.redhat.com> (raw)
In-Reply-To: <mailman.998676421.4273.linux-kernel2news@redhat.com>
In-Reply-To: <mailman.998431141.21252.linux-kernel2news@redhat.com> <200108220004.f7M04Qx01206@devserv.devel.redhat.com> <3B8355D9.7DE64E38@home.com> <20010822165853.A24726@devserv.devel.redhat.com> <mailman.998676421.4273.linux-kernel2news@redhat.com>

> What was you test scenario where you didn't see a completion callback?

The root hub emulation never posts one.

> > +	if (ret == 0) {				/* N.B. Done, must notify */
> > +		/* uhci_call_completion(urb); */ /* ->> uhci_destroy_urb_priv */
> > +		urb->dev = NULL;
> > +		if (urb->complete)
> > +			urb->complete(urb);
> > +	}
> >  
> > -	usb_dec_dev_use(urb->dev);
> > +	usb_dec_dev_use(dev);

> What's all of this for? Protecting against an urb->dev race condition?

No race, but we cannot use urb after callback.

-- Pete

  parent reply	other threads:[~2001-08-24 21:38 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <mailman.998431141.21252.linux-kernel2news@redhat.com>
2001-08-22  0:04 ` PROBLEM: usb not working with 2.4.8-ac8 Pete Zaitcev
2001-08-22  6:48   ` Jordan Breeding
2001-08-22  7:13     ` Pete Zaitcev
2001-08-22 20:58     ` Pete Zaitcev
2001-08-24 18:05       ` Johannes Erdfelt
     [not found]       ` <mailman.998676421.4273.linux-kernel2news@redhat.com>
2001-08-24 21:38         ` Pete Zaitcev [this message]
2001-08-24 21:56           ` Johannes Erdfelt
2001-08-21 20:37 Tobias Diedrich
2001-08-21 21:59 ` Alan Cox
2001-08-21 23:04   ` Tobias Diedrich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200108242138.f7OLc5D12711@devserv.devel.redhat.com \
    --to=zaitcev@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.