From: Stephen Frost <sfrost@snowman.net>
To: Linus Torvalds <torvalds@transmeta.com>
Cc: Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Linux 2.4.10-pre6
Date: Sun, 9 Sep 2001 19:43:13 -0400 [thread overview]
Message-ID: <20010909194313.G11136@ns> (raw)
In-Reply-To: <Pine.LNX.4.33.0109081949510.1097-100000@penguin.transmeta.com>
In-Reply-To: <Pine.LNX.4.33.0109081949510.1097-100000@penguin.transmeta.com>; from torvalds@transmeta.com on Sat, Sep 08, 2001 at 07:52:04PM -0700
[-- Attachment #1: Type: text/plain, Size: 1309 bytes --]
* Linus Torvalds (torvalds@transmeta.com) wrote:
>
> Most noticeable (except perhaps for the NTFS update if you're a NTFS user)
> is that the broken bootdata patch that could cause some spurious MM
> corruption due to a double page free of the bootdata got reverted. This is
> the one that caused BUG reports from mm/page_alloc.c..
The changes to rd.c cause it to fail in compiling. Following
is a patch which I believe to be correct. It fixes the
compilation problem and the module appears to load, work and
unload correctly.
Stephen
--- linux-2.4.10-pre6-orig/drivers/block/rd.c Sun Sep 9 16:19:07 2001
+++ linux/drivers/block/rd.c Sun Sep 9 16:06:59 2001
@@ -259,7 +259,7 @@
/* special: we want to release the ramdisk memory,
it's not like with the other blockdevices where
this ioctl only flushes away the buffer cache. */
- if ((atomic_read(rd_bdev[minor]->bd_openers) > 2))
+ if ((atomic_read(&rd_bdev[minor]->bd_openers) > 2))
return -EBUSY;
destroy_buffers(inode->i_rdev);
rd_blocksizes[minor] = 0;
@@ -372,7 +372,7 @@
struct block_device *bdev = rd_bdev[i];
rd_bdev[i] = NULL;
if (bdev) {
- blkdev_put(bdev);
+ blkdev_put(bdev, BDEV_FILE);
bdput(bdev);
}
destroy_buffers(MKDEV(MAJOR_NR, i));
[-- Attachment #2: Type: application/pgp-signature, Size: 232 bytes --]
prev parent reply other threads:[~2001-09-09 23:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-09-09 2:52 Linux 2.4.10-pre6 Linus Torvalds
2001-09-09 5:29 ` Linux 2.4.10-pre6, NTFS build break John Kacur
2001-09-09 6:38 ` Aaron Lehmann
2001-09-09 12:33 ` Anton Altaparmakov
2001-09-09 9:47 ` Linux 2.4.10-pre6: necessary patches Eyal Lebedinsky
2001-09-09 23:43 ` Stephen Frost [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010909194313.G11136@ns \
--to=sfrost@snowman.net \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.