From: Andrea Arcangeli <andrea@suse.de>
To: Robert Love <rml@tech9.net>
Cc: "Dieter Nützel" <Dieter.Nuetzel@hamburg.de>,
"Andrew Morton" <akpm@zip.com.au>, "Chris Mason" <mason@suse.com>,
"Beau Kuiper" <kuib-kl@ljbc.wa.edu.au>,
"Linux Kernel List" <linux-kernel@vger.kernel.org>,
"ReiserFS List" <reiserfs-list@namesys.com>
Subject: Re: [PATCH] Significant performace improvements on reiserfs systems
Date: Fri, 21 Sep 2001 00:37:42 +0200 [thread overview]
Message-ID: <20010921003742.I729@athlon.random> (raw)
In-Reply-To: <20010920170812.CCCACE641B@ns1.suse.com> <3BAA29C2.A9718F49@zip.com.au> <1001019170.6090.134.camel@phantasy> <200109202112.f8KLCXG16849@zero.tech9.net> <1001024694.6048.246.camel@phantasy>
In-Reply-To: <1001024694.6048.246.camel@phantasy>; from rml@tech9.net on Thu, Sep 20, 2001 at 06:24:48PM -0400
On Thu, Sep 20, 2001 at 06:24:48PM -0400, Robert Love wrote:
> On Thu, 2001-09-20 at 17:11, Dieter Nützel wrote:
> > > I am putting together a conditional scheduling patch to fix some of the
> > > worst cases, for use in conjunction with the preemption patch, and this
> > > might be useful.
> >
> > The conditional_schedule() function hampered me from running it already.
>
> hrm, i didnt notice that conditional_schedule wasnt defined in that
> patch. you will need to do it, but do something more like
>
> if (current->need_resched && current->lock_depth == 0) {
> unlock_kernel();
> lock_kernel();
> }
>
> like Andrew wrote.
nitpicking: the above is fine but it isn't complete, it may work for
most cases but for a generic function it would be better implemented
similarly to release_kernel_lock_save/restore so you take care of
lock_depth > 0 too:
ftp://ftp.us.kernel.org/pub/linux/kernel/people/andrea/kernels/v2.2/2.2.20pre10aa1/72_copy-user-unlock-1
Andrea
next prev parent reply other threads:[~2001-09-20 22:38 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20010920170812.CCCACE641B@ns1.suse.com>
2001-09-20 17:19 ` [PATCH] Significant performace improvements on reiserfs systems Chris Mason
2001-09-20 17:39 ` Andrew Morton
2001-09-20 20:52 ` Robert Love
2001-09-20 21:11 ` Dieter Nützel
[not found] ` <200109202112.f8KLCXG16849@zero.tech9.net>
2001-09-20 22:24 ` Robert Love
2001-09-20 22:37 ` Andrea Arcangeli [this message]
2001-09-20 22:56 ` Robert Love
2001-09-20 23:15 ` Andrea Arcangeli
2001-09-20 23:41 ` Robert Love
2001-09-21 0:37 ` george anzinger
2001-09-21 1:20 ` Andrew Morton
2001-09-21 3:14 ` Robert Love
2001-09-21 9:32 ` [reiserfs-list] " Nikita Danilov
2001-09-21 12:18 ` Alan Cox
2001-09-21 12:31 ` Nikita Danilov
2001-09-23 23:49 ` Rusty Russell
2001-09-20 18:47 ` Andrea Arcangeli
2001-09-20 18:58 ` Andrew Morton
2001-09-20 19:13 ` Andrea Arcangeli
[not found] <200109201708.f8KH8sG15617@zero.tech9.net>
2001-09-20 20:48 ` Robert Love
2001-09-20 17:08 Dieter Nützel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010921003742.I729@athlon.random \
--to=andrea@suse.de \
--cc=Dieter.Nuetzel@hamburg.de \
--cc=akpm@zip.com.au \
--cc=kuib-kl@ljbc.wa.edu.au \
--cc=linux-kernel@vger.kernel.org \
--cc=mason@suse.com \
--cc=reiserfs-list@namesys.com \
--cc=rml@tech9.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.