Re: [parisc-linux] [PATCH] Additional Address cleanup

[Matthew Wilcox <willy@debian.org>]

On Fri, Sep 21, 2001 at 10:48:38AM -0600, Ryan Bradetich wrote:
> The simplification I made was to remove the HPA from index
> 0 of the addr[] in the parisc_device.  I feel this is redundant
> since the device already records the HPA with the hpa field.
> By not including the HPA, it also saves a kmalloc on every
> parisc device to store the HPA, and an additional kfree/kmalloc
> when the device actually has additional addresses to store.

I haven't had time to review the patch, but I think it's an excellent
idea to remove the duplicate hpa and addr[0] entries.  I was thinking
about doing it myself, but hadn't got round to checking it could be done.

I was also thinking about removing the `hpa' entry completely and using
struct resource to track the area claimed by the device.  I think we
want to do this in any case for the card-mode dino support.  This is a
later step, I think, so don't let this consideration slow you down.

-- 
Revolutions do not require corporate support.