From: Benjamin LaHaise <bcrl@redhat.com>
To: "David S. Miller" <davem@redhat.com>
Cc: marcelo@conectiva.com.br, andrea@suse.de, torvalds@transmeta.com,
linux-kernel@vger.kernel.org
Subject: Re: Locking comment on shrink_caches()
Date: Tue, 25 Sep 2001 17:00:55 -0400 [thread overview]
Message-ID: <20010925170055.B19494@redhat.com> (raw)
In-Reply-To: <20010925.131528.78383994.davem@redhat.com> <Pine.LNX.4.21.0109251601360.2193-100000@freak.distro.conectiva> <20010925.132905.32720330.davem@redhat.com>
In-Reply-To: <20010925.132905.32720330.davem@redhat.com>; from davem@redhat.com on Tue, Sep 25, 2001 at 01:29:05PM -0700
On Tue, Sep 25, 2001 at 01:29:05PM -0700, David S. Miller wrote:
> Well, there are two things happing in that patch. Per-hash chain
> locks for the page cache itself, and the lock added to the address
> space for that page list.
Last time I looked, those patches made the already ugly vm locking
even worse. I'd rather try to use some of the rcu techniques for
page cache lookup, and per-page locking for page cache removal
which will lead to *cleaner* code as well as a much more scalable
kernel.
Keep in mind that just because a lock is on someone's hitlist doesn't
mean that it is for the right reasons. Look at the io_request_lock
that is held around the bounce buffer copies in the scsi midlayer.
*shudder*
-ben
next prev parent reply other threads:[~2001-09-25 21:00 UTC|newest]
Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-09-25 17:49 Locking comment on shrink_caches() Marcelo Tosatti
2001-09-25 19:57 ` David S. Miller
2001-09-25 18:40 ` Marcelo Tosatti
2001-09-25 20:15 ` David S. Miller
2001-09-25 19:02 ` Marcelo Tosatti
2001-09-25 20:29 ` David S. Miller
2001-09-25 21:00 ` Benjamin LaHaise [this message]
2001-09-25 21:55 ` David S. Miller
2001-09-25 22:16 ` Benjamin LaHaise
2001-09-25 22:28 ` David S. Miller
2001-09-26 16:40 ` Alan Cox
2001-09-26 17:25 ` Linus Torvalds
2001-09-26 17:40 ` Alan Cox
2001-09-26 17:44 ` Linus Torvalds
2001-09-26 18:01 ` Benjamin LaHaise
2001-09-26 18:01 ` Dave Jones
2001-09-26 20:20 ` Vojtech Pavlik
2001-09-26 20:24 ` Vojtech Pavlik
2001-09-26 17:43 ` Richard Gooch
2001-09-26 18:24 ` Benjamin LaHaise
2001-09-26 18:48 ` Richard Gooch
2001-09-26 18:58 ` Davide Libenzi
2001-09-26 17:45 ` Dave Jones
2001-09-26 17:50 ` Alan Cox
2001-09-26 17:59 ` Dave Jones
2001-09-26 18:07 ` Alan Cox
2001-09-26 18:09 ` Padraig Brady
2001-09-26 18:22 ` Dave Jones
2001-09-26 18:24 ` Linus Torvalds
2001-09-26 18:40 ` Dave Jones
2001-09-26 19:12 ` Linus Torvalds
2001-09-27 12:22 ` CPU frequency shifting "problems" Padraig Brady
2001-09-27 12:44 ` Dave Jones
2001-09-27 23:23 ` Linus Torvalds
2001-09-28 0:55 ` Alan Cox
2001-09-28 2:12 ` Stefan Smietanowski
2001-09-28 8:55 ` Jamie Lokier
2001-09-28 16:11 ` Linus Torvalds
2001-09-28 20:29 ` Eric W. Biederman
2001-09-28 22:24 ` Jamie Lokier
2001-09-26 19:04 ` Locking comment on shrink_caches() George Greer
2001-09-26 18:59 ` George Greer
2001-09-26 23:26 ` David S. Miller
2001-09-27 12:10 ` Alan Cox
2001-09-27 15:38 ` Linus Torvalds
2001-09-27 17:44 ` Ingo Molnar
2001-09-27 19:41 ` David S. Miller
2001-09-27 22:59 ` Alan Cox
2001-09-25 22:03 ` Andrea Arcangeli
2001-09-25 20:24 ` Rik van Riel
2001-09-25 20:28 ` David S. Miller
2001-09-25 21:05 ` Andrew Morton
2001-09-25 21:48 ` David S. Miller
[not found] ` <200109252215.f8PMFDa02034@eng2.beaverton.ibm.com>
2001-09-25 22:26 ` David S. Miller
2001-09-26 17:42 ` Ingo Molnar
2001-09-25 22:01 ` Andrea Arcangeli
2001-09-25 22:03 ` David S. Miller
2001-09-25 22:59 ` Andrea Arcangeli
2001-09-25 20:40 ` Josh MacDonald
2001-09-25 19:25 ` Marcelo Tosatti
2001-09-25 21:57 ` Andrea Arcangeli
-- strict thread matches above, loose matches on Subject: below --
2001-09-26 5:04 Dipankar Sarma
2001-09-26 5:31 ` Andrew Morton
2001-09-26 6:57 ` David S. Miller
2001-09-26 7:08 ` Dipankar Sarma
2001-09-26 16:52 ` John Hawkes
[not found] <fa.cbgmt3v.192gc8r@ifi.uio.no>
[not found] ` <fa.cd0mtbv.1aigc0v@ifi.uio.no>
[not found] ` <i1m66a5o1zc.fsf@verden.pvv.ntnu.no>
2001-09-27 1:34 ` Vojtech Pavlik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010925170055.B19494@redhat.com \
--to=bcrl@redhat.com \
--cc=andrea@suse.de \
--cc=davem@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.