All of lore.kernel.org
 help / color / mirror / Atom feed
From: Erik Andersen <andersen@codepoet.org>
To: Alan Cox <laughing@shared-source.org>, linux-kernel@vger.kernel.org
Subject: Re: Linux 2.4.9-ac17
Date: Fri, 28 Sep 2001 21:21:15 -0600	[thread overview]
Message-ID: <20010928212115.B10265@codepoet.org> (raw)
In-Reply-To: <20010929004412.A1335@lightning.swansea.linux.org.uk> <20010928211027.A10265@codepoet.org>
In-Reply-To: <20010928211027.A10265@codepoet.org>

On Fri Sep 28, 2001 at 09:10:27PM -0600, Erik Andersen wrote:
> On Sat Sep 29, 2001 at 12:44:12AM +0100, Alan Cox wrote:
> > 
> > 2.4.9-ac17
> > o	Next batch of MODULE_LICENSE tags		(Arjan van de Ven)
> 
> 
> gcc -D__KERNEL__ -I/home/andersen/linux/include -Wall -Wstrict-prototypes -Wno-trigraphs -O2 -fomit-frame-pointer -fno-strict-aliasing -fno-common -pipe -mpreferred-stack-boundary=2 -march=i386    -c -o aha1740.o aha1740.c
> aha1740.c:617: parse error before string constant
> aha1740.c:617: warning: type defaults to `int' in declaration of `MODULE_LICENSE'
> aha1740.c:617: warning: function declaration isn't a prototype
> aha1740.c:617: warning: data definition has no type or storage class
> make[4]: *** [aha1740.o] Error 1
> 

Found another silly buglet...


--- linux/drivers/scsi/aha1740.c.orig	Fri Sep 28 08:05:39 2001
+++ linux/drivers/scsi/aha1740.c	Fri Sep 28 08:05:49 2001
@@ -22,10 +22,7 @@
  * if it doesn't work for your devices, take a look.
  */
 
-#ifdef MODULE
 #include <linux/module.h>
-#endif
-
 #include <linux/kernel.h>
 #include <linux/types.h>
 #include <linux/string.h>
--- linux/drivers/scsi/ncr53c8xx.c.orig	Fri Sep 28 08:06:37 2001
+++ linux/drivers/scsi/ncr53c8xx.c	Fri Sep 28 08:06:45 2001
@@ -116,10 +116,7 @@
 
 #define LinuxVersionCode(v, p, s) (((v)<<16)+((p)<<8)+(s))
 
-#ifdef MODULE
 #include <linux/module.h>
-#endif
-
 #include <asm/dma.h>
 #include <asm/io.h>
 #include <asm/system.h>


 -Erik

--
Erik B. Andersen   email:  andersee@debian.org, formerly of Lineo
--This message was written using 73% post-consumer electrons--

  reply	other threads:[~2001-09-29  3:21 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-09-28 23:44 Linux 2.4.9-ac17 Alan Cox
2001-09-29  1:01 ` Mike Fedyk
2001-09-29 14:23   ` Alan Cox
2001-09-29 18:25     ` Hristo Grigorov
2001-09-30  4:29     ` Mike Fedyk
2001-09-29  1:48 ` John Jasen
2001-09-29  2:00   ` Mike Fedyk
2001-09-29 14:31     ` Alan Cox
2001-09-29  3:10 ` Erik Andersen
2001-09-29  3:21   ` Erik Andersen [this message]
2001-09-29  6:44 ` (lkml)Linux 2.4.9-ac17 thunder7

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20010928212115.B10265@codepoet.org \
    --to=andersen@codepoet.org \
    --cc=laughing@shared-source.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.