All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chip Salzenberg <chip@pobox.com>
To: Linux Kernel <linux-kernel@vger.kernel.org>
Cc: Trond Myklebust <trond.myklebust@fys.uio.no>,
	David Mazieres <dm@amsterdam.lcs.mit.edu>
Subject: [PATCH] nfsd 2.4.10: unbloat filehandles for export points
Date: Tue, 2 Oct 2001 16:03:34 -0700	[thread overview]
Message-ID: <20011002160334.B1108@perlsupport.com> (raw)

The otherwise excellent nfsd patches in 2.4.10 accidentally inflated
all filehandles for export points to the max size permitted by NFSv3:
64 bytes.  This problem isn't just cosmetic; it also breaks SFS
(http://sfs.fs.net).  Granted, SFS isn't living quite within the law,
but still there's no reason to inflate filehandles.

Thus, this (tested) patch:

--- linux_o/fs/nfsd/nfsfh.c.old	Thu Sep 20 21:02:01 2001
+++ linux/fs/nfsd/nfsfh.c	Tue Oct  2 15:46:47 2001
@@ -732,6 +732,8 @@
 	struct super_block *sb = dentry->d_inode->i_sb;
 	
-	if (dentry == exp->ex_dentry)
+	if (dentry == exp->ex_dentry) {
+		*maxsize = 0;
 		return 0;
+	}
 
 	if (sb->s_op->dentry_to_fh) {

-- 
Chip Salzenberg               - a.k.a. -              <chip@pobox.com>
 "We have no fuel on board, plus or minus 8 kilograms."  -- NEAR tech

                 reply	other threads:[~2001-10-02 23:03 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20011002160334.B1108@perlsupport.com \
    --to=chip@pobox.com \
    --cc=dm@amsterdam.lcs.mit.edu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=trond.myklebust@fys.uio.no \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.