From: "David S. Miller" <davem@redhat.com>
To: chris@wirex.com
Cc: torvalds@transmeta.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] 2.4.11 min() in tcp.c
Date: Wed, 10 Oct 2001 16:56:59 -0700 (PDT) [thread overview]
Message-ID: <20011010.165659.74564935.davem@redhat.com> (raw)
In-Reply-To: <20011010164430.B19995@figure1.int.wirex.com>
In-Reply-To: <20011010164430.B19995@figure1.int.wirex.com>
From: Chris Wright <chris@wirex.com>
Date: Wed, 10 Oct 2001 16:44:30 -0700
tcp.c:855: warning: comparison of distinct pointer types lacks a cast
the following patch, changes min() to min_t() to make size_t explicit.
Applied, but with a cleanup, please never do this:
- min(
+ min_t (
"min_t" is not a C operator, therefore no reason to put a space
between "min_t" and the openning parenthesis. If you look around,
this is the general coding style rule the Linux code follows:
if () /* <--- space here */
while () /* <--- and here */
foo_function() /* <--- but not here */
For example.
Franks a lot,
David S. Miller
davem@redhat.com
next prev parent reply other threads:[~2001-10-10 23:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-10-10 23:44 [PATCH] 2.4.11 min() in tcp.c Chris Wright
2001-10-10 23:56 ` David S. Miller [this message]
2001-10-11 0:00 ` Chris Wright
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20011010.165659.74564935.davem@redhat.com \
--to=davem@redhat.com \
--cc=chris@wirex.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.