From: Arnaldo Carvalho de Melo <acme@conectiva.com.br>
To: Rasmus Andersen <rasmus@jaquet.dk>
Cc: Adrian Bunk <bunk@fs.tum.de>, Thomas Hood <jdthood@mail.com>,
linux-kernel@vger.kernel.org
Subject: Re: Linux 2.4.10-ac10
Date: Wed, 10 Oct 2001 07:29:17 -0300 [thread overview]
Message-ID: <20011010072916.A1016@conectiva.com.br> (raw)
In-Reply-To: <1002676545.5283.4.camel@thanatos> <Pine.NEB.4.40.0110101032320.28053-200000@mimas.fachschaften.tu-muenchen.de> <20011010110905.A28673@jaquet.dk>
In-Reply-To: <20011010110905.A28673@jaquet.dk>; from rasmus@jaquet.dk on Wed, Oct 10, 2001 at 11:09:05AM +0200
Em Wed, Oct 10, 2001 at 11:09:05AM +0200, Rasmus Andersen escreveu:
> On Wed, Oct 10, 2001 at 10:47:40AM +0200, Adrian Bunk wrote:
> [...]
> >
> > Yes, that was it. Sound works again for me after I've reversed the
> > attached patch to drivers/sound/ad1816.c.
>
> [...]
>
> >
> > - if (check_region (io_base, 16)) {
> > - printk ("ad1816: I/O port 0x%03x not free\n", io_base);
> > - return 0;
> > + if (request_region(io_base, 16, "AD1816 Sound")) {
> > + printk(KERN_WARNING "ad1816: I/O port 0x%03x not free\n",
> > + io_base);
> > + goto err;
> > }
> >
>
> Would you mind trying with a '!' in front of the request_region call?
yup, my fault, sorry, just in case I've checked the other similar patches
I've sent to Alan and they have the '!', thanks for spotting this.
- Arnaldo
next prev parent reply other threads:[~2001-10-10 10:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-10-10 1:15 Linux 2.4.10-ac10 Thomas Hood
2001-10-10 8:47 ` Adrian Bunk
2001-10-10 9:09 ` Rasmus Andersen
2001-10-10 9:30 ` Adrian Bunk
2001-10-10 10:29 ` Arnaldo Carvalho de Melo [this message]
-- strict thread matches above, loose matches on Subject: below --
2001-10-10 9:20 willy tarreau
2001-10-10 9:30 ` Adrian Bunk
2001-10-09 23:40 Thomas Hood
2001-10-09 22:32 Thomas Hood
2001-10-10 1:04 ` Adrian Bunk
2001-10-08 21:57 Alan Cox
2001-10-09 21:39 ` Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20011010072916.A1016@conectiva.com.br \
--to=acme@conectiva.com.br \
--cc=bunk@fs.tum.de \
--cc=jdthood@mail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rasmus@jaquet.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.