Re: [parisc-linux] new glibc dpatch

[Matthew Wilcox <willy@debian.org>]

On Wed, Oct 17, 2001 at 12:14:53AM -0400, Carlos O'Donell Jr. wrote:
> Just a comment about your changes to ./sysdeps/ia64/dl-fptr.c
> 
> =====
> --- glibc22-hppa.dpatch	Tue Oct 16 20:52:02 2001
> +++ glibc22-hppa.dpatch.mw	Tue Oct 16 21:05:27 2001
> @@ -1135,7 +1135,7 @@
>       unsigned int npages;		/* # of pages to allocate */
>   #ifdef _LIBC_REENTRANT
>  -    volatile int lock;
> -+    __atomic_lock_t lock;
> ++    static __atomic_lock_t lock = __ATOMIC_LOCK_INIT;
>       sigset_t full_sigset;
>   #endif
>       /* the next to members MUST be consecutive! */
> =====

I'm not sure what meaning static would have in this context.  It doesn't
have to be initialised because every arch other than PA defines an
unlocked lock to be 0.  If it gets initialised, it gets put in .data
(instead of .bss), even if you're initialising it to 0.  Stupid, I know.

-- 
Revolutions do not require corporate support.