All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chip Salzenberg <chip@pobox.com>
To: Linus Torvalds <torvalds@transmeta.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>
Subject: [PATCH] 2.4.13pre3: &i_mapping used where i_mapping needed
Date: Wed, 17 Oct 2001 11:36:40 -0700	[thread overview]
Message-ID: <20011017113640.A3859@perlsupport.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 343 bytes --]

In 2.4.13pre3, mm/filemap.c:mincore_page() sets an address_space
pointer to &inode->i_mapping.  This is almost surely an error, because
i_mapping is already a pointer.

A minimal patch is attached.
-- 
Chip Salzenberg               - a.k.a. -              <chip@pobox.com>
 "We have no fuel on board, plus or minus 8 kilograms."  -- NEAR tech

[-- Attachment #2: pre3-mapping-typo-1 --]
[-- Type: text/plain, Size: 386 bytes --]


Index: linux/mm/filemap.c
--- linux/mm/filemap.c.old	Tue Oct 16 23:29:08 2001
+++ linux/mm/filemap.c	Wed Oct 17 00:26:37 2001
@@ -2449,5 +2449,5 @@
 {
 	unsigned char present = 0;
-	struct address_space * as = &vma->vm_file->f_dentry->d_inode->i_mapping;
+	struct address_space * as = vma->vm_file->f_dentry->d_inode->i_mapping;
 	struct page * page, ** hash = page_hash(as, pgoff);
 

                 reply	other threads:[~2001-10-17 18:36 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20011017113640.A3859@perlsupport.com \
    --to=chip@pobox.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.