From: "David S. Miller" <davem@redhat.com>
To: bcrl@redhat.com
Cc: alan@lxorguk.ukuu.org.uk, hawkes@oss.sgi.com,
linux-kernel@vger.kernel.org, torvalds@transmeta.com
Subject: Re: [PATCH] gcc 3.0.1 warnings about multi-line literals
Date: Mon, 22 Oct 2001 14:39:58 -0700 (PDT) [thread overview]
Message-ID: <20011022.143958.78707983.davem@redhat.com> (raw)
In-Reply-To: <20011022165157.M23213@redhat.com>
In-Reply-To: <20011022161527.K23213@redhat.com> <E15vlx2-0003HO-00@the-village.bc.nu> <20011022165157.M23213@redhat.com>
From: Benjamin LaHaise <bcrl@redhat.com>
Date: Mon, 22 Oct 2001 16:51:57 -0400
On Mon, Oct 22, 2001 at 09:45:36PM +0100, Alan Cox wrote:
> > Please reject this patch. The gcc folks are wrong in this case.
>
> Im curious - why do you make that specific claim. The multiline literals are
> rather ugly.
Which of the following is more readable:
/* try atomic lock inline, if that fails, spin out of line */
"\tbtsl $1,%0\n"
It's only gross because you decided to make it so, try:
"btsl $1,%0\n\t"
Which is what I use just about everywhere now and I'm prefectly
fine with it.
Franks a lot,
David S. Miller
davem@redhat.com
next prev parent reply other threads:[~2001-10-22 21:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-10-22 20:05 [PATCH] gcc 3.0.1 warnings about multi-line literals John Hawkes
2001-10-22 20:15 ` Benjamin LaHaise
2001-10-22 20:45 ` Alan Cox
2001-10-22 20:51 ` Benjamin LaHaise
2001-10-22 21:39 ` David S. Miller [this message]
2001-10-23 12:04 ` David Howells
2001-10-25 7:11 ` Richard Henderson
2001-10-25 16:47 ` Benjamin LaHaise
2001-10-22 20:51 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20011022.143958.78707983.davem@redhat.com \
--to=davem@redhat.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=bcrl@redhat.com \
--cc=hawkes@oss.sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.