From: Ralf Baechle <ralf@oss.sgi.com>
To: Machida Hiroyuki <machida@sm.sony.co.jp>
Cc: alan@lxorguk.ukuu.org.uk, linux-mips@oss.sgi.com
Subject: Re: csum_ipv6_magic()
Date: Mon, 22 Oct 2001 22:48:28 +0200 [thread overview]
Message-ID: <20011022224828.A20032@dea.linux-mips.net> (raw)
In-Reply-To: <20011022203324G.machida@sm.sony.co.jp>; from machida@sm.sony.co.jp on Mon, Oct 22, 2001 at 08:33:24PM +0900
On Mon, Oct 22, 2001 at 08:33:24PM +0900, Machida Hiroyuki wrote:
> I found bugs in checksum.h. A sample fix is attached below.
>
> I perfer to use generic csum_ipv6_magic() in net/checksum.h
> than this fix. Please someone show me improvements for this asm
> version of csum_ipv6_magic().
The C version should produce code that performs identically on MIPS. As
such we have no good reason to keep the assembler version.
> * (csum_ipv6_magic): Have same paramter types as net/checksum.h.
> Correct carry computation. Add a final carry.
The len argument of that prototype should be __u32 because of IPv6
jumbograms.
Ralf
next prev parent reply other threads:[~2001-10-22 20:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-10-22 6:16 csum_ipv6_magic() Machida Hiroyuki
2001-10-22 7:55 ` csum_ipv6_magic() Alan Cox
2001-10-22 7:55 ` csum_ipv6_magic() Alan Cox
2001-10-22 10:56 ` csum_ipv6_magic() Machida Hiroyuki
2001-10-22 11:33 ` csum_ipv6_magic() Machida Hiroyuki
2001-10-22 20:48 ` Ralf Baechle [this message]
2001-10-23 5:07 ` csum_ipv6_magic() Machida Hiroyuki
2001-10-23 11:18 ` csum_ipv6_magic() Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20011022224828.A20032@dea.linux-mips.net \
--to=ralf@oss.sgi.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-mips@oss.sgi.com \
--cc=machida@sm.sony.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.