From: Benjamin LaHaise <bcrl@redhat.com>
To: Linus Torvalds <torvalds@transmeta.com>
Cc: linux-kernel@vger.kernel.org
Subject: please revert bogus patch to vmscan.c
Date: Mon, 29 Oct 2001 18:08:37 -0500 [thread overview]
Message-ID: <20011029180837.F25434@redhat.com> (raw)
The following:
@@ -50,7 +50,6 @@
/* Don't look at this pte if it's been accessed recently. */
if (ptep_test_and_clear_young(page_table)) {
- flush_tlb_page(vma, address);
mark_page_accessed(page);
return 0;
}
is completely bogus. Without the tlb flush, the system may never update
the accessed bit on a page that is heavily being used.
-ben
--
Fish.
next reply other threads:[~2001-10-29 23:08 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-10-29 23:08 Benjamin LaHaise [this message]
2001-10-29 23:14 ` please revert bogus patch to vmscan.c David S. Miller
2001-10-29 23:15 ` Benjamin LaHaise
2001-10-29 23:25 ` Linus Torvalds
2001-10-29 23:33 ` Benjamin LaHaise
2001-10-29 23:36 ` David S. Miller
2001-10-29 23:39 ` Benjamin LaHaise
2001-10-29 23:41 ` Linus Torvalds
2001-10-29 23:48 ` Benjamin LaHaise
2001-10-29 23:50 ` David S. Miller
2001-10-29 23:51 ` Benjamin LaHaise
2001-10-29 23:55 ` David S. Miller
2001-10-29 23:57 ` Benjamin LaHaise
2001-10-30 0:01 ` David S. Miller
2001-10-30 0:05 ` Benjamin LaHaise
2001-10-29 23:58 ` Linus Torvalds
2001-10-30 1:31 ` Rik van Riel
2001-10-30 1:34 ` David S. Miller
2001-10-30 1:42 ` Linus Torvalds
2001-10-30 1:46 ` David S. Miller
2001-10-30 2:25 ` Benjamin LaHaise
2001-10-30 15:20 ` Andrea Arcangeli
2001-10-30 15:34 ` Rik van Riel
2001-10-30 15:51 ` Andrea Arcangeli
2001-10-30 16:34 ` Benjamin LaHaise
2001-10-30 17:00 ` Andrea Arcangeli
2001-10-30 17:07 ` Rik van Riel
2001-10-30 16:13 ` Giuliano Pochini
2001-10-30 16:54 ` Andrea Arcangeli
2001-10-30 17:23 ` Giuliano Pochini
2001-10-30 17:30 ` Andrea Arcangeli
2001-10-31 0:38 ` Paul Mackerras
[not found] ` <15327.8495.767553.389519@cargo.ozlabs.ibm.com>
2001-10-31 1:57 ` Andrea Arcangeli
2001-10-30 16:38 ` Linus Torvalds
2001-10-30 16:47 ` Benjamin LaHaise
2001-10-30 16:57 ` Victor Yodaiken
2001-10-30 17:16 ` Troy Benjegerdes
2001-10-30 17:17 ` Linus Torvalds
2001-10-30 17:51 ` Victor Yodaiken
2001-10-30 18:01 ` Cort Dougan
2001-10-30 21:39 ` Paul Mackerras
2001-10-30 22:36 ` Victor Yodaiken
2001-10-30 17:23 ` Benjamin Herrenschmidt
2001-10-30 17:36 ` Benjamin Herrenschmidt
2001-10-30 17:41 ` Linus Torvalds
2001-10-30 1:49 ` Benjamin LaHaise
2001-10-30 9:03 ` Alan Cox
2001-10-29 23:22 ` Linus Torvalds
2001-10-29 23:29 ` Benjamin LaHaise
2001-10-29 23:44 ` Linus Torvalds
2001-10-30 0:02 ` Hugh Dickins
2001-10-30 0:04 ` Linus Torvalds
2001-10-30 0:04 ` David S. Miller
2001-10-29 23:51 ` Paul Mackerras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20011029180837.F25434@redhat.com \
--to=bcrl@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.