Re: Something broken in sys_swapon

[Simon Kirby <sim@netnation.com>]

On Sat, Nov 03, 2001 at 03:31:25PM -0500, Alexander Viro wrote:

> On Sat, 3 Nov 2001, Simon Kirby wrote:
> 
> >                 kdev_t dev = swap_inode->i_rdev;
> >                 struct block_device_operations *bdops;
> > 
> >                 p->swap_device = dev;
> >                 set_blocksize(dev, PAGE_SIZE);
> > 
> > I don't know much at all about the inode structure, but doesn't this set
> > the block size of the originating filesystem containing the inode rather
> > than the block device that inode happens to be pointing to?  That would
> 
> man 2 stat
> 
> i_rdev is equivalent of st_rdev, i_dev - of st_dev.

Okay, would you see any other reason why my root filesystem would
completely blow up after swapon /dev/hdb2 when /dev/hdb no longer exists?

All I did was remove /dev/hdb and forget to take the swap entry out of
/etc/fstab.  On boot I got "attempt to access beyond end of device"
messages looping endlessly.  I tried once with / mounted rw (it looks
like Debian still has / mounted ro when it turns on swap), and lots of
filesystem corruption resulted.

Simon-

[  Stormix Technologies Inc.  ][  NetNation Communications Inc. ]
[       sim@stormix.com       ][       sim@netnation.com        ]
[ Opinions expressed are not necessarily those of my employers. ]