All of lore.kernel.org
 help / color / mirror / Atom feed
From: "David S. Miller" <davem@redhat.com>
To: maxk@qualcomm.com
Cc: pcg@goof.com, linux-kernel@vger.kernel.org
Subject: Re: 2.4.13-ac5 && vtun not working
Date: Tue, 06 Nov 2001 15:32:31 -0800 (PST)	[thread overview]
Message-ID: <20011106.153231.39156880.davem@redhat.com> (raw)
In-Reply-To: <5.1.0.14.0.20011031095211.0dbc23f0@mail1>
In-Reply-To: <20011031.003056.63128206.davem@redhat.com> <20011031104323.A2263@schmorp.de> <5.1.0.14.0.20011031095211.0dbc23f0@mail1>

   From: Maksim Krasnyanskiy <maxk@qualcomm.com>
   Date: Wed, 31 Oct 2001 09:55:47 -0800

   Here is the patch for TUN/TAP to remove that suboptimality :). 
   So we won't call dev_alloc_name if name is not a template.

This won't work.  The whole purpose of calling dev_alloc_name
is to twofold:

1) Make sure the name string is unique

2) Copy that name into dev->name if it is unique

I'm going to change dev_alloc_name() to allow non-'%' names
instead, that is a better fix.

Franks a lot,
David S. Miller
davem@redhat.com

  reply	other threads:[~2001-11-06 23:33 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-10-30  1:17 2.4.13-ac5 && vtun not working Lehmann 
2001-10-30  1:39 ` Lehmann 
2001-10-30  1:48 ` Maksim Krasnyanskiy
2001-10-30  1:53   ` David S. Miller
2001-10-31  0:05     ` Lehmann 
2001-10-31  8:30       ` David S. Miller
2001-10-31  9:43         ` Lehmann 
2001-10-31 17:55         ` Maksim Krasnyanskiy
2001-11-06 23:32           ` David S. Miller [this message]
2001-11-06 23:53           ` Maksim Krasnyanskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20011106.153231.39156880.davem@redhat.com \
    --to=davem@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maxk@qualcomm.com \
    --cc=pcg@goof.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.