From: John Levon <moz@compsoc.man.ac.uk>
To: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Adding KERN_INFO to some printks #2
Date: Sat, 10 Nov 2001 13:44:34 +0000 [thread overview]
Message-ID: <20011110134434.A94031@compsoc.man.ac.uk> (raw)
In-Reply-To: <01110913474600.02130@nemo> <1005321383.1209.8.camel@phantasy> <01110923204702.00807@nemo> <1005342348.808.18.camel@phantasy>
In-Reply-To: <1005342348.808.18.camel@phantasy>
On Fri, Nov 09, 2001 at 04:45:48PM -0500, Robert Love wrote:
> I went over the patch and found a few things...
>
> printk(KERN_INFO "No local APIC present or hardware disabled\n");
>
> I'd make this a KERN_WARNING. Consider the case where I compile my own
> kernel and I add APIC support. If the driver is failing to find my APIC
> then either (a) my BIOS is broken or (b) I should remove the driver.
> Either way I would want to know.
This isn't what's happening - check apic.c. It is re-enabled if possible,
or a local APIC really doesn't exist. Either way I don't see the point
in a warning.
regards
john
--
"I know I believe in nothing but it is my nothing"
- Manic Street Preachers
prev parent reply other threads:[~2001-11-10 13:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-11-09 13:47 [PATCH] Adding KERN_INFO to some printks #2 vda
2001-11-09 15:56 ` Robert Love
2001-11-09 23:20 ` vda
2001-11-09 21:32 ` Alan Cox
2001-11-09 23:31 ` vda
2001-11-09 21:52 ` Robert Love
2001-11-09 22:26 ` George Greer
2001-11-09 21:45 ` Robert Love
2001-11-10 0:07 ` vda
2001-11-10 13:44 ` John Levon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20011110134434.A94031@compsoc.man.ac.uk \
--to=moz@compsoc.man.ac.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.