From: Pete Zaitcev <zaitcev@redhat.com>
To: Kai Germaschewski <kai@tp1.ruhr-uni-bochum.de>
Cc: linux-kernel@vger.kernel.org,
Linus Torvalds <torvalds@transmeta.com>,
Pete Zaitcev <zaitcev@redhat.com>
Subject: Re: [PATCH] save sound mixer state over suspend
Date: Mon, 12 Nov 2001 00:47:19 -0500 [thread overview]
Message-ID: <20011112004719.A6091@devserv.devel.redhat.com> (raw)
In-Reply-To: <Pine.LNX.4.33.0111112107530.1518-100000@vaio>
In-Reply-To: <Pine.LNX.4.33.0111112107530.1518-100000@vaio>; from kai@tp1.ruhr-uni-bochum.de on Sun, Nov 11, 2001 at 09:42:27PM +0100
> Date: Sun, 11 Nov 2001 21:42:27 +0100 (CET)
> From: Kai Germaschewski <kai@tp1.ruhr-uni-bochum.de>
> To: <linux-kernel@vger.kernel.org>
> cc: Linus Torvalds <torvalds@transmeta.com>, Pete Zaitcev <zaitcev@redhat.com>
> The appended patch introduces two new functions to the ac97_codec
> handling: ac97_save_state() and ac97_restore_state().
> These functions save/restore the mixer state over suspend. (So after
> resume the volume is the same it was before)
The patch itself looks ok, but I am wondering what is
the difference between your ac97_restore_state and ac97_reset.
I think you may be reinventing the wheel here.
I cannot test the patch because my suspend/resume cycle
retains mixer levels without it (2.2.14 stock, PCG-Z505JE),
so I would not see any difference.
-- Pete
next prev parent reply other threads:[~2001-11-12 5:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-11-11 20:42 [PATCH] save sound mixer state over suspend Kai Germaschewski
2001-11-12 5:47 ` Pete Zaitcev [this message]
2001-11-12 6:03 ` Jeff Garzik
2001-11-12 8:40 ` Kai Germaschewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20011112004719.A6091@devserv.devel.redhat.com \
--to=zaitcev@redhat.com \
--cc=kai@tp1.ruhr-uni-bochum.de \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.