From: "David S. Miller" <davem@redhat.com>
To: neilb@cse.unsw.edu.au
Cc: trond.myklebust@fys.uio.no, nfs@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: Re: Fix knfsd readahead cache in 2.4.15
Date: Mon, 26 Nov 2001 15:53:47 -0800 (PST) [thread overview]
Message-ID: <20011126.155347.45872112.davem@redhat.com> (raw)
In-Reply-To: <15362.53694.192797.275363@esther.cse.unsw.edu.au>
In-Reply-To: <15362.18626.303009.379772@charged.uio.no> <15362.53694.192797.275363@esther.cse.unsw.edu.au>
From: Neil Brown <neilb@cse.unsw.edu.au>
Date: Tue, 27 Nov 2001 10:35:26 +1100 (EST)
This is definately a bug, but I don't think it is quite as dramatic as
you suggest.
The "struct raparms" that ra points to will almost always be the last
one on the list, so ra->p_next will almost always be NULL anyway.
Nevertheless, it is a bug and your fix looks good.
There are other problems remaining, this function is a logical
mess.
1) depth is computed in the loop, but thrown away.
It is basically reassigned to a constant before
being used to index the statistics it is for.
2) raparm_cache is reassigned, and since the ra param list is
NULL terminated this can make the list shorter and shorter
and shorter until it is one entry deep.
Yikes :)
next prev parent reply other threads:[~2001-11-26 23:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-11-26 13:50 Fix knfsd readahead cache in 2.4.15 Trond Myklebust
2001-11-26 23:35 ` Neil Brown
2001-11-26 23:53 ` David S. Miller [this message]
2001-11-27 0:05 ` David S. Miller
2001-11-27 0:29 ` Neil Brown
2001-11-27 0:33 ` David S. Miller
2001-11-27 1:25 ` [NFS] " Benjamin LaHaise
2001-11-27 13:54 ` Trond Myklebust
2001-11-27 15:23 ` Benjamin LaHaise
2001-11-27 15:44 ` Trond Myklebust
2001-11-28 21:03 ` Benjamin LaHaise
[not found] <15362.18626.303009.379772@charged.uio.no.suse.lists.linux.kernel>
[not found] ` <15362.53694.192797.275363@esther.cse.unsw.edu.au.suse.lists.linux.kernel>
[not found] ` <20011126.155347.45872112.davem@redhat.com.suse.lists.linux.kernel>
2001-11-27 7:16 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20011126.155347.45872112.davem@redhat.com \
--to=davem@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@cse.unsw.edu.au \
--cc=nfs@lists.sourceforge.net \
--cc=trond.myklebust@fys.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.