All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andreas Dilger <adilger@turbolabs.com>
To: Andrew Morton <akpm@zip.com.au>
Cc: Daniel Kobras <kobras@tat.physik.uni-tuebingen.de>,
	Oliver Xymoron <oxymoron@waste.org>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: ext3: kjournald and spun-down disks
Date: Mon, 26 Nov 2001 17:18:37 -0700	[thread overview]
Message-ID: <20011126171837.P730@lynx.no> (raw)
In-Reply-To: <Pine.LNX.4.40.0111231859510.4162-100000@waste.org> <3BFEF71A.F32176FE@zip.com.au>, <3BFEF71A.F32176FE@zip.com.au>; <20011127002525.A2912@pelks01.extern.uni-tuebingen.de> <3C02D2D3.B8BE11A3@zip.com.au>
In-Reply-To: <3C02D2D3.B8BE11A3@zip.com.au>; from akpm@zip.com.au on Mon, Nov 26, 2001 at 03:40:03PM -0800

On Nov 26, 2001  15:40 -0800, Andrew Morton wrote:
> Daniel Kobras wrote:
> > Is there a way to tell which kjournald process is associated to which
> > partition? A fake cmdline, or an fd to the partition's device node that
> > shows up in /proc/<pid>/fd would indeed be quite helpful.
> 
> Andreas has a patch which puts the device major/minor into kjournald's
> process name.

It is in CVS HEAD, but appears not to be in the branches.  It is below.
This should not have a problem with the 16-byte command length, because
kdevname() only returns strings of the form mm:nn, so my system has:


root         8     1  0 08:58 ?        00:00:11 [kjournald-03:07]
root        39     1  0 08:58 ?        00:00:00 [kjournald-03:05]
root        40     1  0 08:58 ?        00:00:00 [kjournald-03:09]
root        41     1  0 08:58 ?        00:00:00 [kjournald-03:0a]
root      1219     1  0 09:23 ?        00:00:02 [kjournald-3a:01]

Which are all within 16 bytes (including NUL), until we get larger
major/minor numbers.

Cheers, Andreas
===========================================================================
diff -u -u -r1.11.2.2 -r1.52
--- fs/jbd/journal.c	2001/11/11 05:11:06	1.11.2.2
+++ fs/jbd/journal.c	2001/11/27 00:10:39	1.52
@@ -210,7 +176,7 @@
 	recalc_sigpending(current);
 	spin_unlock_irq(&current->sigmask_lock);
 
-	sprintf(current->comm, "kjournald");
+	sprintf(current->comm, "kjournald-%s", kdevname(journal->j_dev));
 
 	/* Set up an interval timer which can be used to trigger a
 	    commit wakeup after the commit interval expires */
--
Andreas Dilger
http://sourceforge.net/projects/ext2resize/
http://www-mddsp.enel.ucalgary.ca/People/adilger/


  reply	other threads:[~2001-11-27  0:21 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-11-24  1:10 ext3: kjournald and spun-down disks Oliver Xymoron
2001-11-24  1:25 ` Andrew Morton
2001-11-24  1:58   ` Oliver Xymoron
2001-11-24  2:32     ` Andrew Morton
2001-11-26  3:15       ` Oliver Xymoron
2001-11-26  3:34         ` Andrew Morton
2001-11-26 15:22           ` Oliver Xymoron
2001-11-26 23:25   ` Daniel Kobras
2001-11-26 23:40     ` Andrew Morton
2001-11-27  0:18       ` Andreas Dilger [this message]
2001-11-27  0:03     ` Andre Hedrick
2001-11-27  0:21     ` Oliver Xymoron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20011126171837.P730@lynx.no \
    --to=adilger@turbolabs.com \
    --cc=akpm@zip.com.au \
    --cc=kobras@tat.physik.uni-tuebingen.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oxymoron@waste.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.