From: Jan Harkes <jaharkes@cs.cmu.edu>
To: Pavel Machek <pavel@suse.cz>
Cc: kernel list <linux-kernel@vger.kernel.org>
Subject: Re: ENTRY macro (coda maintainers please listen)
Date: Mon, 3 Dec 2001 15:58:06 -0500 [thread overview]
Message-ID: <20011203155805.A7057@cs.cmu.edu> (raw)
In-Reply-To: <20011202215232.A1751@elf.ucw.cz>
In-Reply-To: <20011202215232.A1751@elf.ucw.cz>
On Sun, Dec 02, 2001 at 09:52:32PM +0100, Pavel Machek wrote:
> linux/linkage.h includes macro "ENTRY(a)", while linux/coda_linux
> includes ... macro "ENTRY".
That could lead to a possible problem. We're just lucky that no file in
the Coda code has __ASSEMBLY__ defined.
> It would be good to rename one of them (they are probably not needed
> in one module, anyway, that's not clean)...
Actually all coda_XXX.h files don't even have to be in include/linux/,
only coda.h contains structs/defines that should be 'visible' outside of
the Coda kernel code, anything else should just go to fs/coda and get a
good dust off to remove a bunch of cruft.
> Oh and there's no entry for CODA in MAINTAINERS file. You probably
> want to fix that.
Gee, oh well. I didn't consider it 'critical bug-fixes only' or
important enough to push a patch for a maintainers entry into a stable
series, and obviously wasn't paying attention during 2.3 development.
Besides I've been sending you updates whenever something critical
changes in coda.o (considering you are using it for podfuk). I would
figure that of all people at least you would know.
Jan
next prev parent reply other threads:[~2001-12-04 0:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-12-02 20:52 ENTRY macro (coda maintainers please listen) Pavel Machek
2001-12-03 20:58 ` Jan Harkes [this message]
2001-12-03 23:02 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20011203155805.A7057@cs.cmu.edu \
--to=jaharkes@cs.cmu.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.