From: "David S. Miller" <davem@redhat.com>
To: rth@redhat.com
Cc: davidm@hpl.hp.com, schwab@suse.de, linux-ia64@linuxia64.org,
marcelo@conectiva.com.br, torvalds@transmeta.com,
linux-kernel@vger.kernel.org
Subject: Re: alpha bug in signal handling
Date: Wed, 05 Dec 2001 03:23:04 -0800 (PST) [thread overview]
Message-ID: <20011205.032304.102576056.davem@redhat.com> (raw)
In-Reply-To: <20011204190048.B8179@redhat.com>
In-Reply-To: <20011204171426.B7982@redhat.com> <15373.33622.236872.92057@napali.hpl.hp.com> <20011204190048.B8179@redhat.com>
From: Richard Henderson <rth@redhat.com>
Date: Tue, 4 Dec 2001 19:00:48 -0800
On Tue, Dec 04, 2001 at 06:15:50PM -0800, David Mosberger wrote:
> Oh, sorry, I was referring to teh *other* problem... ;-)
>
> What I meant is that the check for re-scheduling
> (current->need_resched) and signal deliverify (current->sigpending)
> needs to be done with interrupts turned off, and the interrupts need
> to be left off until user space is reached. Otherwise, you could get
> an interrupt which would wake up a higher priority task or post a
> signal between the check and the return to user space.
>
> I didn't see this interrupt disabling in the Alpha version of entry.S,
> but I have to admit my Alpha assembly is getting quite rusty.
Oh, yes, I see. This should fix it.
I don't understand why this is even necessary.
What if the interrupt comes in on another processor. How does this
return from trap behavior avoid that interrupt modifying the signal
and/or scheduling state wrt. the current cpu's task?
I think the change is bogus, we don't do this on sparc64 and things
have been perfectly fine.
And if the change isn't necessary, it's bad to disable interrupts for
a longer period of time than necessary.
next prev parent reply other threads:[~2001-12-05 11:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <jepu5xqnva.fsf@sykes.suse.de>
[not found] ` <15372.13000.922405.379605@napali.hpl.hp.com>
[not found] ` <20011204171426.B7982@redhat.com>
[not found] ` <15373.33622.236872.92057@napali.hpl.hp.com>
2001-12-05 3:00 ` alpha bug in signal handling Richard Henderson
2001-12-05 11:23 ` David S. Miller [this message]
2001-12-05 16:58 ` Richard Henderson
2001-12-05 20:17 ` David S. Miller
2001-12-05 20:55 ` Paul Mackerras
2001-12-05 21:15 ` Benjamin Herrenschmidt
2001-12-06 1:09 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20011205.032304.102576056.davem@redhat.com \
--to=davem@redhat.com \
--cc=davidm@hpl.hp.com \
--cc=linux-ia64@linuxia64.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
--cc=rth@redhat.com \
--cc=schwab@suse.de \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.