From: Jens Axboe <axboe@suse.de>
To: Ivan Kokshaysky <ink@jurassic.park.msu.ru>
Cc: linux-kernel@vger.kernel.org
Subject: Re: new bio: compile fix for alpha
Date: Thu, 6 Dec 2001 19:23:18 +0100 [thread overview]
Message-ID: <20011206182318.GI4996@suse.de> (raw)
In-Reply-To: <20011129165456.A13610@jurassic.park.msu.ru> <20011129152339.M10601@suse.de> <20011206204330.A608@jurassic.park.msu.ru>
In-Reply-To: <20011206204330.A608@jurassic.park.msu.ru>
On Thu, Dec 06 2001, Ivan Kokshaysky wrote:
> On Thu, Nov 29, 2001 at 03:23:39PM +0100, Jens Axboe wrote:
> > Please send whatever you find, thanks.
>
> Well, I think this one is critical - in -pre4 BIO_CONTIG macro
> has been changed:
> - (bio_to_phys((bio)) + bio_size((bio)) == bio_to_phys((nxt)))
> + (bvec_to_phys(__BVEC_END((bio)) + (bio)->bi_size) ==bio_to_phys((nxt)))
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> This means that you add size in bytes to the `struct bio_vec' pointer,
> which is obviously bogus. I wonder why this typo didn't expose itself
> on x86 - on alpha I've got an oops on very first disk i/o in partition
> check...
Irk, good spotting. Thanks!
> The rest is cleaning up some format vs. arg inconsistency on 64-bit
> platforms.
> Oh, and yet another [incorrect] BUG_ON macro on alpha killed.
Applied, although I think we'll make BUG_ON a kernel generic and not
platform specific as per Rusty's patch.
--
Jens Axboe
next prev parent reply other threads:[~2001-12-06 18:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-11-29 13:54 new bio: compile fix for alpha Ivan Kokshaysky
2001-11-29 14:23 ` Jens Axboe
2001-12-06 17:43 ` Ivan Kokshaysky
2001-12-06 18:23 ` Jens Axboe [this message]
2001-12-06 18:39 ` Jeff V. Merkey
2001-12-07 14:51 ` Jens Axboe
2001-12-07 10:10 ` Ivan Kokshaysky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20011206182318.GI4996@suse.de \
--to=axboe@suse.de \
--cc=ink@jurassic.park.msu.ru \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.