From: Stephan von Krawczynski <skraw@ithnet.com>
To: Keith Owens <kaos@ocs.com.au>
Cc: m.luca@iname.com, linux-kernel@vger.kernel.org
Subject: Re: Linux 2.4.17-pre5
Date: Fri, 7 Dec 2001 15:25:11 +0100 [thread overview]
Message-ID: <20011207152511.178ff974.skraw@ithnet.com> (raw)
In-Reply-To: <32470.1007732114@ocs3.intra.ocs.com.au>
In-Reply-To: <20011207125530.40a13b87.skraw@ithnet.com> <32470.1007732114@ocs3.intra.ocs.com.au>
On Sat, 08 Dec 2001 00:35:14 +1100
Keith Owens <kaos@ocs.com.au> wrote:
> On Fri, 7 Dec 2001 12:55:30 +0100,
> Stephan von Krawczynski <skraw@ithnet.com> wrote:
> >There is a problem: I made a (really small) patch to Config.in saying:
> >
> > int ' Maximum number of cards supported by HiSax'
CONFIG_HISAX_MAX_CARDS 8
> >
> >If I check this in the source, it gives me CONFIG_HISAX_MAX_CARDS as (8)
>
> Yuck! CML1 outputs integers as #define CONFIG_foo (number) instead of
> just number. CML2 does not do that, I was looking at CML2. Add this
> to drivers/isdn/Makefile
>
> CFLAGS_foo.o += -DMAX_CARDS=$(subst (,,$(subst ),,$(CONFIG_HISAX_MAX_CARDS)))
>
> In foo.c, use MAX_CARDS instead of CONFIG_HISAX_MAX_CARDS. Change foo
> to the name of the object that you are working on. When you build, it
> should say -DMAX_CARDS=8.
Thanks for this hint, but it is not all that easy. Problem is the definition is
needed for _all_ files in the hisax-subtree, to be more precise for all
currently including hisax.h. I am not very fond of the idea to add additional
conditions to the availability of the HISAX_MAX_CARDS symbol, especially if
they are located in the Makefile.
Anyway, how would you generate this additional -D for all files inside a
certain directory? Obviously the stuff should at least be put inside the
hisax-Makefile, and not one layer above in isdn-Makefile.
I tried "CFLAGS += ..." but that does not work.
Thanks for help,
Stephan
next prev parent reply other threads:[~2001-12-07 14:26 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-12-06 20:44 Linux 2.4.17-pre5 Luca Montecchiani
2001-12-07 0:12 ` Stephan von Krawczynski
2001-12-07 3:43 ` Keith Owens
2001-12-07 11:55 ` Stephan von Krawczynski
2001-12-07 13:35 ` Keith Owens
2001-12-07 14:25 ` Stephan von Krawczynski [this message]
2001-12-07 16:39 ` Linux 2.4.17-pre5 / Have fun with make Stephan von Krawczynski
2001-12-07 22:21 ` Keith Owens
-- strict thread matches above, loose matches on Subject: below --
2001-12-06 17:39 Linux 2.4.17-pre5 Marcelo Tosatti
2001-12-06 19:07 ` Alan Cox
2001-12-06 23:38 ` Dave Jones
2001-12-07 0:09 ` Alan Cox
2001-12-08 10:46 ` Rusty Russell
2001-12-09 0:31 ` Alan Cox
2001-12-09 1:58 ` Rusty Russell
2001-12-09 2:35 ` Davide Libenzi
2001-12-09 6:20 ` Rusty Russell
2001-12-09 16:24 ` Alan Cox
2001-12-09 19:48 ` Davide Libenzi
2001-12-09 22:44 ` Mike Kravetz
2001-12-09 23:50 ` Davide Libenzi
2001-12-09 23:57 ` Alan Cox
2001-12-19 22:16 ` Pavel Machek
2001-12-20 19:10 ` Davide Libenzi
2001-12-09 16:16 ` Alan Cox
2001-12-10 0:21 ` Rusty Russell
2001-12-10 0:41 ` Alan Cox
2001-12-10 2:10 ` Martin J. Bligh
2001-12-10 5:40 ` Rusty Russell
2001-12-10 5:31 ` Rusty Russell
2001-12-10 8:28 ` Alan Cox
2001-12-10 23:12 ` James Cleverdon
2001-12-10 23:30 ` Alan Cox
2001-12-11 9:16 ` Robert Varga
2001-12-11 9:23 ` David Weinehall
2001-12-11 9:00 ` Eric W. Biederman
2001-12-11 23:14 ` Alan Cox
2001-12-09 19:38 ` Marcelo Tosatti
2001-12-09 9:47 ` arjan
2001-12-07 16:07 ` Marcelo Tosatti
2001-12-06 19:18 ` Matthias Andree
2001-12-06 19:05 ` Marcelo Tosatti
2001-12-06 21:14 ` Ben Greear
2001-12-06 21:58 ` David S. Miller
2001-12-06 22:24 ` Matthias Andree
2001-12-09 10:10 ` Eran Man
2001-12-06 20:14 ` Rik van Riel
2001-12-06 20:22 ` Jeff Garzik
2001-12-06 20:58 ` David S. Miller
2001-12-08 4:56 ` M. Edward Borasky
2001-12-08 5:41 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20011207152511.178ff974.skraw@ithnet.com \
--to=skraw@ithnet.com \
--cc=kaos@ocs.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=m.luca@iname.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.