All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@suse.de>
To: "Adam J. Richter" <adam@yggdrasil.com>
Cc: linux-kernel@vger.kernel.org, pat@it.com.au, tfries@umr.edu,
	ankry@mif.pg.gda.pl, torvalds@transmeta.com
Subject: Re: Patch?: linux-2.5.1-pre7/drivers/block/xd.c compilation fixes
Date: Sat, 8 Dec 2001 10:06:24 +0100	[thread overview]
Message-ID: <20011208090624.GJ32569@suse.de> (raw)
In-Reply-To: <20011207220808.A6037@baldur.yggdrasil.com>
In-Reply-To: <20011207220808.A6037@baldur.yggdrasil.com>

On Fri, Dec 07 2001, Adam J. Richter wrote:
> 	I do not know the whole new block IO interface, but here
> is my attempt at making linux-2.4.17-pre7/drivers/block/xd.c compile.
> If I got any of this wrong, I would appreciate someone telling me,
> because I may start tring to fix some of the other 90+ drivers that
> do not compile in 2.4.1-pre7 later this weekend.

That would be great! The fix looks good -- what you want to add in
addition is checking that this is a rw request. So before your switch,
do something ala

	/*
	 * we don't support special requests
	 */
	if (!(CURRENT->flags & REQ_CMD)) {
		blkdev_dequeue_request(CURRENT);
		end_that_request_first(CURRENT, 0, CURRENT->nr_sectors);
		end_that_request_last(CURRENT);
		continue;
	}

-- 
Jens Axboe


      reply	other threads:[~2001-12-08  9:06 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-12-08  6:08 Patch?: linux-2.5.1-pre7/drivers/block/xd.c compilation fixes Adam J. Richter
2001-12-08  9:06 ` Jens Axboe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20011208090624.GJ32569@suse.de \
    --to=axboe@suse.de \
    --cc=adam@yggdrasil.com \
    --cc=ankry@mif.pg.gda.pl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pat@it.com.au \
    --cc=tfries@umr.edu \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.