All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephan von Krawczynski <skraw@ithnet.com>
To: Christian Laursen <xi@borderworlds.dk>
Cc: linux-kernel@vger.kernel.org
Subject: Re: NULL pointer dereference in moxa driver
Date: Wed, 12 Dec 2001 00:23:53 +0100	[thread overview]
Message-ID: <200112112323.AAA23377@webserver.ithnet.com> (raw)
In-Reply-To: <m37krtl6cv.fsf@borg.borderworlds.dk>

> Stephan von Krawczynski <skraw@ithnet.com> writes:                  
> Seems I got somewhat closer now.                                    
>                                                                     
> After reading the documentation again, I realised that I was        
accessing                                                             
> the wrong device.                                                   
>                                                                     
> I belive I read in another file, that the second board started at   
> device 32. However device 8 is the first port on the second board.  
>                                                                     
> And actually that seems to work. (I cant confirm this 100% before   
> I get to work tomorrow and actually attach something to the port)   
                                                                      
Well, this driver does only support 32 Ports. everyone more crashes   
definitely. I haven't seen such a broken source in years. I urge you  
to delete the device nodes above 31 to overcome any chance to crash   
again.                                                                
                                                                      
Most interestingly the moxa-driver is better by far than the mxser. It
seems to me the mxser is _really_ old. If you want to help us all,    
please try to contact moxa support and tell them it is high time to   
submit a _new_ mxser.c to the kernel tree, because the old (currently 
used) one is such a mess. They can do better (proven in moxa.c).      
At least a multiboard setup is completely broken. My patch fixes this 
but this does not help the main kernel tree.                          
                                                                      
I cannot submit a patch to marcelo, because I am not the maintainer,  
and we all don't want to fork a new mxser-driver apart from the       
original.                                                             
                                                                      
Oh dear.                                                              
                                                                      
Regards,                                                              
Stephan                                                               
                                                                      
                                                                      
                                                                      
                                                                      

       reply	other threads:[~2001-12-11 23:24 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <m37krtl6cv.fsf@borg.borderworlds.dk>
2001-12-11 23:23 ` Stephan von Krawczynski [this message]
2001-12-11 23:51   ` NULL pointer dereference in moxa driver Alan Cox
2001-12-11 23:29     ` Tim Hockin
2001-12-12  2:48       ` Stephan von Krawczynski
2001-12-11 23:58     ` Christian Laursen
2001-12-10 17:53 Christian Laursen
2001-12-10 18:26 ` Christian Laursen
2001-12-10 18:40 ` Stephan von Krawczynski
2001-12-10 19:12   ` Christian Laursen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200112112323.AAA23377@webserver.ithnet.com \
    --to=skraw@ithnet.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=xi@borderworlds.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.