All of lore.kernel.org
 help / color / mirror / Atom feed
From: Russell King <rmk@arm.linux.org.uk>
To: Telford002@aol.com
Cc: linux-kernel@vger.kernel.org
Subject: Re: TTY Driver Open and Close Logic
Date: Tue, 18 Dec 2001 16:48:40 +0000	[thread overview]
Message-ID: <20011218164840.B13126@flint.arm.linux.org.uk> (raw)
In-Reply-To: <e5.10e6703a.29509786@aol.com>
In-Reply-To: <e5.10e6703a.29509786@aol.com>; from Telford002@aol.com on Tue, Dec 18, 2001 at 07:58:46AM -0500

On Tue, Dec 18, 2001 at 07:58:46AM -0500, Telford002@aol.com wrote:
> I have been working on various serial drivers and I notice that physical
> driver close routine is called in all cases even if the physical driver
> open routine fails.  That suggests to me that a lot of the MOD_DEC/INC_COUNT
> logic in serial.c and other physical serial drivers is incorrect.  As
> serial.c seems usually to be compiled into the kernel the issue
> is not so important, but a lot of the other logic associated with
> open counts also seems incorrect.  Is this observation correct?

Absolutely 100% correct.

--
Russell King (rmk@arm.linux.org.uk)                The developer of ARM Linux
             http://www.arm.linux.org.uk/personal/aboutme.html


      parent reply	other threads:[~2001-12-18 16:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-12-18 12:58 TTY Driver Open and Close Logic Telford002
2001-12-18 14:16 ` Alan Cox
2001-12-18 16:55   ` Russell King
2001-12-18 16:48 ` Russell King [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20011218164840.B13126@flint.arm.linux.org.uk \
    --to=rmk@arm.linux.org.uk \
    --cc=Telford002@aol.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.