From: Dave Jones <davej@suse.de>
To: "Kevin P. Fleming" <kevin@labsysgrp.com>
Cc: marcelo@conectiva.com.br, linux-kernel@vger.kernel.org,
andre@linux-ide.org, axboe@suse.de
Subject: Re: [PATCH] ide-probe does not set removable flag for ide-floppy devices
Date: Fri, 28 Dec 2001 02:06:45 +0000 [thread overview]
Message-ID: <20011228020645.A10548@suse.de> (raw)
In-Reply-To: <009c01c1842a$d281f670$6caaa8c0@kevin>
In-Reply-To: <009c01c1842a$d281f670$6caaa8c0@kevin>
On Thu, Dec 13, 2001 at 04:06:39PM -0700, Kevin P. Fleming wrote:
> Small patch, relative to 2.4.17-pre8, but should apply to any recent version
>
> diff -urN -X dontdiff linux/drivers/ide/ide-probe.c
> linux-new/drivers/ide/ide-probe.c
> --- linux/drivers/ide/ide-probe.c Wed Dec 12 11:01:24 2001
> +++ linux-new/drivers/ide/ide-probe.c Sun Dec 9 11:41:15 2001
> @@ -122,6 +122,7 @@
> printk("cdrom or floppy?, assuming ");
> if (drive->media != ide_cdrom) {
> printk ("FLOPPY");
> + drive->removable = 1;
> break;
> }
> }
<nitpick old mails time>
To me, this looks like it would make more sense to set this to 1 _before_
the switch statement, and set to 0 as necessary, as most of the cases
look removable to me. Should cut out a few lines of code, and also mark
things like ide-tape as removable in the process too. Or is this not
desired behaviour for some reason ?
Dave.
--
Dave Jones. http://www.codemonkey.org.uk
SuSE Labs.
prev parent reply other threads:[~2001-12-28 2:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-12-13 23:06 [PATCH] ide-probe does not set removable flag for ide-floppy devices Kevin P. Fleming
2001-12-14 20:28 ` Marcelo Tosatti
2001-12-28 2:06 ` Dave Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20011228020645.A10548@suse.de \
--to=davej@suse.de \
--cc=andre@linux-ide.org \
--cc=axboe@suse.de \
--cc=kevin@labsysgrp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.