From: Andreas Dilger <adilger@turbolabs.com>
To: Oliver Xymoron <oxymoron@waste.org>
Cc: Daniel Phillips <phillips@bonn-fries.net>,
linux-kernel@vger.kernel.org, ext2-devel@lists.sourceforge.net
Subject: Re: [Ext2-devel] [RFC] [PATCH] Clean up fs.h union for ext2
Date: Sat, 29 Dec 2001 14:01:05 -0700 [thread overview]
Message-ID: <20011229140105.A12868@lynx.no> (raw)
In-Reply-To: <20011227111415.D12868@lynx.no> <Pine.LNX.4.43.0112290957050.18183-100000@waste.org>
In-Reply-To: <Pine.LNX.4.43.0112290957050.18183-100000@waste.org>; from oxymoron@waste.org on Sat, Dec 29, 2001 at 10:04:24AM -0600
On Dec 29, 2001 10:04 -0600, Oliver Xymoron wrote:
> On Thu, 27 Dec 2001, Andreas Dilger wrote:
> > Minor nit: this is already done for the ext3 code, but it looks like:
> >
> > #define EXT3_I (&((inode)->u.ext3_i))
> >
> > We already have the EXT3_SB, so I thought I would be consistent with it:
> >
> > #define EXT3_SB (&((sb)->u.ext3_sb))
> >
> > Do people like the inline version better? Either way, I would like to make
> > the ext2 and ext3 codes more similar, rather than less.
>
> The ext3 macros are rather revolting, simply because they assume the
> variable name. A parameterized macro might be the best compromise:
>
> #define EXT2_I(i) (&(i->u.ext2_inode_info))
My mistake, the Ext3 macros _do_ take an inode/sb parameter. It's not that
I'm a huge fan of macros over inline functions, it's just that I would like
to have a consensus about how it should be done so that it is consistent
between ext2 and ext3.
Cheers, Andreas
--
Andreas Dilger
http://sourceforge.net/projects/ext2resize/
http://www-mddsp.enel.ucalgary.ca/People/adilger/
next prev parent reply other threads:[~2001-12-29 21:02 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-12-27 3:21 [RFC] [PATCH] Clean up fs.h union for ext2 Daniel Phillips
2001-12-27 3:28 ` Legacy Fishtank
2001-12-27 3:35 ` Arnaldo Carvalho de Melo
2001-12-27 3:52 ` Daniel Phillips
2002-01-05 14:29 ` Anton Altaparmakov
2002-01-05 14:47 ` Daniel Phillips
2002-01-05 14:56 ` Anton Altaparmakov
2002-01-06 3:32 ` Daniel Phillips
2002-01-06 4:04 ` Anton Altaparmakov
2002-01-06 22:42 ` Daniel Phillips
2002-01-07 0:30 ` Anton Altaparmakov
2002-01-07 1:27 ` Arnaldo Carvalho de Melo
2002-01-07 2:12 ` Daniel Phillips
2002-01-07 2:18 ` Arnaldo Carvalho de Melo
2002-01-07 2:22 ` Arnaldo Carvalho de Melo
2001-12-27 18:14 ` [Ext2-devel] " Andreas Dilger
2001-12-28 1:55 ` Daniel Phillips
2001-12-29 16:04 ` Oliver Xymoron
2001-12-29 21:01 ` Andreas Dilger [this message]
2001-12-29 21:30 ` Oliver Xymoron
2001-12-29 21:08 ` Andrew Morton
2002-01-02 10:26 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20011229140105.A12868@lynx.no \
--to=adilger@turbolabs.com \
--cc=ext2-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=oxymoron@waste.org \
--cc=phillips@bonn-fries.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.