From: kuznet@ms2.inr.ac.ru
To: alan@lxorguk.UKuu.ORG.UK (Alan Cox)
Cc: linux-kernel@vger.kernel.org
Subject: Re: AX25/socket kernel PATCHes
Date: Sat, 29 Dec 2001 23:37:18 +0300 (MSK) [thread overview]
Message-ID: <200112292037.XAA12592@ms2.inr.ac.ru> (raw)
In-Reply-To: <E16KNor-00059i-00@the-village.bc.nu> from "Alan Cox" at Dec 29, 1 09:15:00 pm
Hello!
> So that it checks
> < skb2->data || nh.raw > ..
>
> Let me know if that fixes it. It shouldn't but it would be good to know if
> we are picking up header only frames somewhere, or nh.raw has accidentally
> been pushed on one header too far.
Indeed... This fix would be right in any case.
I want to remind why this check is made: this pointer must not show
to heavens and it must not be NULL. This property was not held in the past,
hence this bug trap was inserted. It can be relaxed, provided it preserves
its sanitizing function.
Also, note that real value of nh.raw is private to protocol.
Particularly, it can be equal to mac.raw. The best thing to do is
to set it to the same position as it would have if the same packet
appeared on input. But it is not an absolute requirement,
as soon as raw packet socket cannot hold it.
Alexey
next prev parent reply other threads:[~2001-12-29 20:38 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-12-28 16:41 link error in SCC driver Wichert Akkerman
2001-12-28 16:56 ` Dave Jones
2001-12-28 16:59 ` Wichert Akkerman
2001-12-28 17:08 ` Daniel T. Chen
2001-12-28 20:57 ` AX25/socket kernel PATCHes Henk de Groot
2001-12-28 23:09 ` Alan Cox
2001-12-28 23:15 ` Jeroen Vreeken
2001-12-29 17:29 ` Henk de Groot
2001-12-29 17:27 ` Henk de Groot
2001-12-29 18:02 ` Alan Cox
2001-12-29 20:37 ` kuznet [this message]
2001-12-29 23:56 ` Henk de Groot
2001-12-30 2:27 ` Alan Cox
2001-12-30 17:23 ` Henk de Groot
2001-12-30 22:13 ` Henk de Groot
2001-12-30 22:24 ` Sandor Dibuz
2002-01-01 22:32 ` Henk de Groot
2001-12-29 3:39 ` link error in SCC driver Keith Owens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200112292037.XAA12592@ms2.inr.ac.ru \
--to=kuznet@ms2.inr.ac.ru \
--cc=alan@lxorguk.UKuu.ORG.UK \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.