From: Andreas Dilger <adilger@turbolabs.com>
To: Jeff Garzik <jgarzik@mandrakesoft.com>
Cc: Alexander Viro <viro@math.psu.edu>,
Daniel Phillips <phillips@bonn-fries.net>,
torvalds@transmeta.com, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org, ext2-devel@lists.sourceforge.net
Subject: Re: [Ext2-devel] [PATCH 7/7 v2] Re: PATCH 2.5.2.9: ext2 unbork fs.h (part 1/7)
Date: Mon, 7 Jan 2002 16:49:21 -0700 [thread overview]
Message-ID: <20020107164921.J777@lynx.no> (raw)
In-Reply-To: <Pine.GSO.4.21.0201071401450.6842-100000@weyl.math.psu.edu> <3C3A2F0E.4A132214@mandrakesoft.com>
In-Reply-To: <3C3A2F0E.4A132214@mandrakesoft.com>; from jgarzik@mandrakesoft.com on Mon, Jan 07, 2002 at 06:28:14PM -0500
On Jan 07, 2002 18:28 -0500, Jeff Garzik wrote:
> --- linux-fs6/fs/ext2/ext2_fs_i.h Mon Sep 17 20:16:30 2001
> +++ linux-fs7/fs/ext2/ext2_fs_i.h Mon Jan 7 05:08:38 2002
> @@ -36,6 +36,10 @@
> __u32 i_prealloc_count;
> __u32 i_dir_start_lookup;
> int i_new_inode:1; /* Is a freshly allocated inode */
> +
> +#ifdef __KERNEL__
> + struct inode i_inode_data;
> +#endif
> };
Since ext2_fs_i.h only describes the in-memory data for ext2 inodes, there
is no reason to #ifdef __KERNEL__ any changes therein. I have seen several
other people worry about changes to this file in the past also, and I was
going to suggest adding a comment to the file, but I see it already says
"inode data in memory" so I don't know what else to add...
Cheers, Andreas
--
Andreas Dilger
http://sourceforge.net/projects/ext2resize/
http://www-mddsp.enel.ucalgary.ca/People/adilger/
next prev parent reply other threads:[~2002-01-07 23:51 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-01-07 13:21 PATCH 2.5.2.9: ext2 unbork fs.h (part 1/7) Jeff Garzik
2002-01-07 14:13 ` Anton Altaparmakov
2002-01-07 15:33 ` Daniel Phillips
2002-01-07 21:27 ` Jeff Garzik
2002-01-08 6:32 ` Daniel Phillips
2002-01-08 6:31 ` Jeff Garzik
2002-01-08 6:38 ` Daniel Phillips
2002-01-07 16:01 ` Anton Altaparmakov
2002-01-07 16:23 ` Daniel Phillips
2002-01-07 17:25 ` Mark Zealey
2002-01-07 15:19 ` Daniel Phillips
2002-01-07 20:54 ` Juan Quintela
2002-01-08 4:10 ` Daniel Phillips
2002-01-07 21:25 ` Jeff Garzik
2002-01-08 3:06 ` Daniel Phillips
2002-01-07 23:48 ` Jeff Garzik
2002-01-08 0:15 ` Andreas Dilger
2002-01-08 0:17 ` Jeff Garzik
2002-01-08 3:28 ` Daniel Phillips
2002-01-07 16:10 ` Daniel Phillips
2002-01-07 19:38 ` Alexander Viro
2002-01-07 21:37 ` Jeff Garzik
2002-01-07 23:28 ` [PATCH 7/7 v2] " Jeff Garzik
2002-01-07 23:49 ` Andreas Dilger [this message]
2002-01-07 23:52 ` [Ext2-devel] " Jeff Garzik
2002-01-07 21:32 ` Jeff Garzik
2002-01-07 21:49 ` Arnaldo Carvalho de Melo
2002-01-07 21:58 ` Jeff Garzik
2002-01-07 23:46 ` Jeff Garzik
2002-01-08 0:17 ` [Ext2-devel] " Andreas Dilger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020107164921.J777@lynx.no \
--to=adilger@turbolabs.com \
--cc=ext2-devel@lists.sourceforge.net \
--cc=jgarzik@mandrakesoft.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=phillips@bonn-fries.net \
--cc=torvalds@transmeta.com \
--cc=viro@math.psu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.